Closed Bug 1435547 Opened 3 years ago Closed 3 years ago

Make the today-pane sidebar header look like the main toolbar.

Categories

(Calendar :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(4 files)

The actual today-pane sidebar header looks different in color and size to the main toolbar.

Make it look like the toolbar, also make it as tall as the toolbar would make it more homogen and makes the pane more a part of the main content.
Attached patch today-pane.patchSplinter Review
I moved more code to the common file. On Mac I removed the special spin buttons and use the same as Linux and Windows use. This looks also better on the now taller sidebar header.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8948173 - Flags: review?(philipp)
Comment on attachment 8948173 [details] [diff] [review]
today-pane.patch

Review of attachment 8948173 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good to me, can you show me a screenshot?
Attachment #8948173 - Flags: review?(philipp) → review+
Attached image Screenshot on Linux
Attached image Screenshot on Mac
Attached image Screenshot on Windows
Keywords: checkin-needed
Perfect, looks great! Thanks :)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8ebb03cbea92
Use the toolbar look for the today-pane sidebar header. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.2
I think, the two macOS-specific images (spin-buttons{-active}.png) could have been removed with this patch.
In earlier bugs, Philipp wanted to leave no more used files in the tree. If this is no more desired I can make a bug to remove all this files.
Philipp, can you shed some light on the issue discussed in comment#8 and comment#9, please?
Flags: needinfo?(philipp)
Answered in bug 1446748#c57 .
Flags: needinfo?(philipp)
You need to log in before you can comment on or make changes to this bug.