Open Bug 1435556 Opened 3 years ago Updated 2 months ago
Write changed records back to the mirror and assert the remote tree in tests
59 bytes, text/x-review-board-request
Our mirror tests currently do something like this to make sure we're uploading the correct records: https://searchfox.org/mozilla-central/rev/e06af9c36a73a27864302cd2f829e6200dee8541/toolkit/components/places/tests/sync/test_bookmark_value_changes.js#972-981 (Most of them don't check cleartexts, just IDs). We already run `assertLocalTree` after merging to make sure Places is consistent. It would also be great to write the changed records that `apply` returns back to the mirror (simulating what the engine does in https://searchfox.org/mozilla-central/rev/e06af9c36a73a27864302cd2f829e6200dee8541/services/sync/modules/engines/bookmarks.js#827-829,832), and add an `assertRemoteTree` helper to ensure the tree in our mirror is consistent.
Whiteboard: [good next bug]
hi @kitcambridge. I have already previously contributed to Bugzilla by resolving issues #1446721 and #1428434 and I would like to take on a more interesting issues like this one. Could you please assign this issue to me and give me a little overview of the sync tests system? Thank you.
(In reply to constfilin from comment #3) > hi @kitcambridge. I have already previously contributed to Bugzilla by > resolving issues #1446721 and #1428434 and I would like to take on a more > interesting issues like this one. Could you please assign this issue to me > and give me a little overview of the sync tests system? Thank you. Hi constfilin, thanks for contributing! In comment 2, Kit has a patch and other information that should help get you started, and information on running tests can be found at https://developer.mozilla.org/en-US/docs/Mozilla/QA/Running_automated_tests - in this case, Kit has made some changes to "xpcshell" tests. We'll happily assign this bug to you once you put a patch up asking for feedback - and please feel free to come back here to ask any questions you might have along the way. Good luck, and thanks for contributing!
You need to log in before you can comment on or make changes to this bug.