Handle Null filenames in CacheIR spewer

RESOLVED FIXED in Firefox 60

Status

()

Core
JavaScript Engine: JIT
P3
normal
RESOLVED FIXED
19 days ago
17 days ago

People

(Reporter: mgaudet, Assigned: mgaudet)

Tracking

(Blocks: 1 bug)

Trunk
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Currently the CacheIR spewer can misbehave if the script filename is null (as is the case in jit-test/tests/basic/null-filename-Error.js
Created attachment 8948193 [details] [diff] [review]
Handle null script filenames in CacheIR spew

Scripts can have null as a filename, as evidenced by jit-test/tests/basic/null-filename-Error.js
Attachment #8948193 - Flags: review?(evilpies)
Assignee: nobody → mgaudet
Status: NEW → ASSIGNED
Comment on attachment 8948193 [details] [diff] [review]
Handle null script filenames in CacheIR spew

Review of attachment 8948193 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/CacheIRSpewer.cpp
@@ +78,4 @@
>  {
>      MOZ_ASSERT(enabled());
>      JSONPrinter& j = json.ref();
> +    const char * filename = gen.script_->filename();

nit: const char*
Attachment #8948193 - Flags: review?(evilpies) → review+
Created attachment 8948260 [details] [diff] [review]
Handle null script filenames in CacheIR spew

Carrying r+ from evilpie
Attachment #8948193 - Attachment is obsolete: true
Attachment #8948260 - Flags: review+
Keywords: checkin-needed

Comment 4

17 days ago
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56056bad50c0
Handle null script filenames in CacheIR spew r=evilpie
Keywords: checkin-needed
Status: ASSIGNED → NEW
Priority: -- → P3
Status: NEW → ASSIGNED

Comment 5

17 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/56056bad50c0
Status: ASSIGNED → RESOLVED
Last Resolved: 17 days ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.