Closed Bug 1435570 Opened 2 years ago Closed 2 years ago

Handle Null filenames in CacheIR spewer

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: mgaudet, Assigned: mgaudet)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Currently the CacheIR spewer can misbehave if the script filename is null (as is the case in jit-test/tests/basic/null-filename-Error.js
Scripts can have null as a filename, as evidenced by jit-test/tests/basic/null-filename-Error.js
Attachment #8948193 - Flags: review?(evilpies)
Assignee: nobody → mgaudet
Status: NEW → ASSIGNED
Comment on attachment 8948193 [details] [diff] [review]
Handle null script filenames in CacheIR spew

Review of attachment 8948193 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/CacheIRSpewer.cpp
@@ +78,4 @@
>  {
>      MOZ_ASSERT(enabled());
>      JSONPrinter& j = json.ref();
> +    const char * filename = gen.script_->filename();

nit: const char*
Attachment #8948193 - Flags: review?(evilpies) → review+
Carrying r+ from evilpie
Attachment #8948193 - Attachment is obsolete: true
Attachment #8948260 - Flags: review+
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56056bad50c0
Handle null script filenames in CacheIR spew r=evilpie
Keywords: checkin-needed
Status: ASSIGNED → NEW
Priority: -- → P3
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/56056bad50c0
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.