1435589 - Find toolbar does not find the next/previous correctly in all matches

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P1)

Description

[magicp]

Attachment: steps-to-reproduce_20180204_160220.mp4

Steps to reproduce:

1. Launch Nightly
2. Go to https://www.mozilla.org/en-US/firefox/nightly/firstrun
3. Open Find Toolbar (Ctrl+F)
4. Find "firefox" > Result is 9 matches
5. Click "Find the next" button repeatedly in all matches
6. Click "Find the previous" button repeatedly in all matches


Actual results:

In step 5,
1 of 9 matches -> 2 -> 3 -> 4 -> 5 -> 6 -> 1  (7 to 9 are skipped)

In step 6,
1 of 9 matches -> 9 -> 6 -> 5 -> 4 -> 3 -> 2 -> 1 (8 to 7 are skipped)

Social links (7 to 9) are skipped.
"Find the next" and "Find the previous" have different skip behavior. 


Expected results:
Don't skip social links. Find toolbar should find the next/previous correctly in all matches.

Google Chrome: Works fine as expected.
Microsoft Edge: Works fine as expected (also social links are highlighted)


Regression range:

[Social links are skipped]
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e6510aeb4e94df029cc47d2d00cd2f19ba5cc9d3&tochange=59045a9d7990aaa8262e28a6bccfda2ca82ecd68

[Different skip behavior]
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7f841ee580b9745b6d75649619411295e863ed6e&tochange=3464e112b7d4e2be1a5900b7fa7c125f17226b5f

Comment 1

[Oriol Brufau [:Oriol]]

Due to this bug I couldn't find I219-V in the list of supported products in https://downloadcenter.intel.com/download/25016/?product=82186 when the list is scrolled to the bottom and the window is maximized.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e6510aeb4e94df029cc47d2d00cd2f19ba5cc9d3&tochange=59045a9d7990aaa8262e28a6bccfda2ca82ecd68

Comment 2

[Mike de Boer [:mikedeboer]]

Brad, do you have time to check out what might be going wrong here?

magicp, does this still happen for you? Brad recently fixed a few regressions, which might have inadvertently fixed this bug too!

Comment 3

[Oriol Brufau [:Oriol]]

What I described in comment 1 has been fixed in bug 1436431.

Comment 4

[Brad Werth [:bradwerth]]

Looks like Bug 1436431 has fixed these issues.

Comment 5

[Mike de Boer [:mikedeboer]]

\o/