1435591 - this.node is null PanelMultiView.jsm:140 when closing Bookmarks panel in Library button

Status: NEW

(Firefox :: Menus, defect, P3)

Description

[magicp]

Steps to reproduce:
1. Launch Nightly
2. Click Library button > Bookmarks
3. Close the panel using clicking outside area

Actual results:
The following error is logged in the browser console.

this.node is null PanelMultiView.jsm:140


Expected results:
No error.


Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4949b8ab4d340a87b54912b39d40ea9d7936b120&tochange=15e5dcaa825751d2c7fa9b170e0d3e9306025301

Comment 1

[Sam Foster [:sfoster] (he/him)]

:paolo, is this exception something that will be caught in your current work on PMV? 

The changeset in the regression range has shown up in other (preferences) UI bugs. This bug seems to be mostly concerned with the uncaught exception rather than actual UI impact - assuming those are in fact separate issues.

Comment 2

[:Paolo Amadini]

(In reply to Sam Foster [:sfoster] from comment #1)
> :paolo, is this exception something that will be caught in your current work
> on PMV? 

So, in theory we should already null-check this.node after each "await" statement, because the panel can be destroyed at any time. We also have to do the same when views are requested by another PanelMultiView during a transition. I'm working on addressing both issues at the same time.

> The changeset in the regression range has shown up in other (preferences) UI
> bugs. This bug seems to be mostly concerned with the uncaught exception
> rather than actual UI impact - assuming those are in fact separate issues.

These are likely separate issues. If any of these regressions is related to bug 1424264, just link them there as dependencies and I'll look into them.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.