Closed
Bug 1435618
Opened 6 years ago
Closed 6 years ago
Windows QR debug jobs are all broken with crashes
Categories
(Core :: Graphics: WebRender, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: kats, Assigned: emilio)
References
Details
Attachments
(1 file)
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=qr%20windows&group_state=expanded&fromchange=f949dab7ca907dbd81cf90d4c42ef881cc31f462&tochange=44b20b38eb65f73996a486dae288f66066bf65fd Something landed recently (I suspect bug 1435200) that caused all the windows QR debug jobs to crash on startup.
|
Reporter | |
Comment 1•6 years ago
|
||
FYI to sheriffs so they stop starring these failures with random other bugs.
Flags: needinfo?(ncsoregi)
Flags: needinfo?(nbeleuzu)
Flags: needinfo?(csabou)
Flags: needinfo?(cbrindusan)
Flags: needinfo?(aryx.bugmail)
|
||
Updated•6 years ago
|
Flags: needinfo?(ncsoregi)
|
Assignee | |
Comment 2•6 years ago
|
||
This is trivial to fix, it's perma-leaking a reference to the gfx info service.
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → emilio
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8948265 [details] Bug 1435618: Don't leak a reference to the gfx info. https://reviewboard.mozilla.org/r/217764/#review223516 Patch looks fine but I'm not sure how a leak would cause the crash that we were seeing.
Attachment #8948265 -
Flags: review?(bugmail) → review+
|
|
Assignee | |
Comment 6•6 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #5) > Comment on attachment 8948265 [details] > Bug 1435618: Don't leak a reference to the gfx info. > > https://reviewboard.mozilla.org/r/217764/#review223516 > > Patch looks fine but I'm not sure how a leak would cause the crash that we > were seeing. The already_AddRefed destructor asserts on debug builds.
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/fed46d84d30d Don't leak a reference to the gfx info. r=kats
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7c090dc7f018 followup: Add missing include to unbust windows. r=me
|
||
Updated•6 years ago
|
Flags: needinfo?(aryx.bugmail)
|
||
Updated•6 years ago
|
Blocks: stage-wr-nightly
Priority: -- → P1
|
|
Reporter | |
Updated•6 years ago
|
Flags: needinfo?(nbeleuzu)
Flags: needinfo?(csabou)
Flags: needinfo?(cbrindusan)
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fed46d84d30d https://hg.mozilla.org/mozilla-central/rev/7c090dc7f018
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•