1435634 - Stop refresh driver's timer if the presshell is destroyed in resize event callbacks

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

When we dispatch resize events, we bail out from the loop for processing resize events [1], but we don't call StopTimer() there.  We should do it, and also bail out from the function instead of bailing out from the loop.

I was going to ask Olli to review, but he is on vacation now, so I try :tnikkel instead. 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb44162a1aa2057dfb9264261609f661b1441616

[1] https://hg.mozilla.org/mozilla-central/file/ef1fefe4c6d1/layout/base/nsRefreshDriver.cpp#l1868

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1435634 - Stop refresh driver's timer and bail out if either the prescontext or the presshell was destroyed in resize event callbacks.

Review commit: https://reviewboard.mozilla.org/r/217776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217776/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1435634: Don't make the dispatch of resize events look into the observer list twice unnecessarily.

Just something I noticed while sneaking into bug 1435634.

RemoveElement returns whether the element was actually removed, so no need to
use Contains to bail out.

Review commit: https://reviewboard.mozilla.org/r/217780/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217780/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8948283 [details]
Bug 1435634: Don't make the dispatch of resize events look into the observer list twice unnecessarily.

https://reviewboard.mozilla.org/r/217780/#review223506

Wow!  Good catch!

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8948283 [details]
Bug 1435634: Don't make the dispatch of resize events look into the observer list twice unnecessarily.

Blerg, sorry, this was supposed to be in bug 1435636, but I messed up the bug number, will land it there.

Comment 5

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8948282 [details]
Bug 1435634 - Stop refresh driver's timer and bail out if either the prescontext or the presshell was destroyed in resize event callbacks.

https://reviewboard.mozilla.org/r/217776/#review223844

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29ce9b309a2c
Stop refresh driver's timer and bail out if either the prescontext or the presshell was destroyed in resize event callbacks. r=tnikkel

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/29ce9b309a2c