Closed Bug 1435634 Opened 2 years ago Closed 2 years ago

Stop refresh driver's timer if the presshell is destroyed in resize event callbacks

Categories

(Core :: Layout, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(1 file, 1 obsolete file)

When we dispatch resize events, we bail out from the loop for processing resize events [1], but we don't call StopTimer() there.  We should do it, and also bail out from the function instead of bailing out from the loop.

I was going to ask Olli to review, but he is on vacation now, so I try :tnikkel instead. 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb44162a1aa2057dfb9264261609f661b1441616

[1] https://hg.mozilla.org/mozilla-central/file/ef1fefe4c6d1/layout/base/nsRefreshDriver.cpp#l1868
Comment on attachment 8948283 [details]
Bug 1435634: Don't make the dispatch of resize events look into the observer list twice unnecessarily.

https://reviewboard.mozilla.org/r/217780/#review223506

Wow!  Good catch!
Attachment #8948283 - Flags: review?(hikezoe) → review+
Comment on attachment 8948283 [details]
Bug 1435634: Don't make the dispatch of resize events look into the observer list twice unnecessarily.

Blerg, sorry, this was supposed to be in bug 1435636, but I messed up the bug number, will land it there.
Attachment #8948283 - Attachment is obsolete: true
Attachment #8948283 - Flags: review+
Comment on attachment 8948282 [details]
Bug 1435634 - Stop refresh driver's timer and bail out if either the prescontext or the presshell was destroyed in resize event callbacks.

https://reviewboard.mozilla.org/r/217776/#review223844
Attachment #8948282 - Flags: review?(tnikkel) → review+
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29ce9b309a2c
Stop refresh driver's timer and bail out if either the prescontext or the presshell was destroyed in resize event callbacks. r=tnikkel
https://hg.mozilla.org/mozilla-central/rev/29ce9b309a2c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.