Closed
Bug 1435655
Opened 7 years ago
Closed 7 years ago
History engine: set.add is not a function
Categories
(Firefox :: Sync, defect, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: eoger, Assigned: tcsc)
Details
Attachments
(1 file)
This is on my Windows bootcamp partition that hasn't synced for a long long time:
> 1517799068140 Sync.Status DEBUG Status for engine history: error.engine.reason.unknown_fail
> 1517799068140 Sync.Status DEBUG Status.service: success.status_ok => error.sync.failed_partial
> 1517799068140 Sync.ErrorHandler DEBUG history failed: TypeError: set.add is not a function (resource://services-sync/util.js:534:7) JS Stack trace: setAddAll@util.js:534:7 < _processIncoming@engines.js:1189:24 < async*_processIncoming@history.js:66:13 < async*_sync@engines.js:1791:13 < async*WrappedNotify@util.js:181:27 < async*sync@engines.js:725:12 < async*_syncEngine@enginesync.js:208:13 < async*sync@enginesync.js:156:21 < async*onNotify@service.js:1130:13 < async*WrappedNotify@util.js:181:27 < async*WrappedLock@util.js:137:22 < async*_lockedSync@service.js:1123:12 < async*sync/<@service.js:1115:13 < async*WrappedCatch@util.js:107:22 < async*sync@service.js:1104:12 < async*syncAndReportErrors/<@policies.js:826:7
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8948431 [details]
Bug 1435655 - Ensure we properly initialize previousFailed and toFetch
https://reviewboard.mozilla.org/r/217882/#review223654
Thanks!
Attachment #8948431 -
Flags: review?(eoger) → review+
Updated•7 years ago
|
Assignee: nobody → tchiovoloni
Priority: -- → P1
Comment 3•7 years ago
|
||
Thom, can you please try and untangle what versions are affected and if we can/should uplift a fix?
Flags: needinfo?(tchiovoloni)
Assignee | ||
Comment 4•7 years ago
|
||
It's a regression from 1429250, so it doesn't need an uplift.
Flags: needinfo?(tchiovoloni)
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5436a03fe01b
Ensure we properly initialize previousFailed and toFetch r=eoger
Comment 6•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•