1435696 - Windows build broken: mozilla/a11y/HandlerProvider.h(63): error C2061: syntax error: identifier 'IARelationData'

Status: RESOLVED DUPLICATE of bug 1420119

(Core :: Disability Access APIs, defect)

Description

[:Gijs (he/him)]

30:11.06 builds\opt\dist\include\mozilla/a11y/HandlerProvider.h(63): error C2061: syntax error: identifier 'IARelationData'
30:11.06 builds\opt\dist\include\mozilla/a11y/HandlerProvider.h(93): error C2061: syntax error: identifier 'IARelationData'
30:11.06 builds\opt\dist\include\mozilla/a11y/HandlerProvider.h(63): error C3668: 'mozilla::a11y::HandlerProvider::get_RelationsInfo': method with override specifier 'override' did not override any base class methods
30:11.06 mozmake.EXE[4]: *** [mozilla-central/config/rules.mk:1049: COMPtrTypes.obj] Error 2
30:11.06 mozmake.EXE[4]: *** Waiting for unfinished jobs....
30:12.98 xpcAccEvents.cpp
30:13.29 Unified_cpp_accessible_html0.cpp
30:13.30 accessible_html.lib.desc
30:13.87 Unified_cpp_accessible_base0.cpp
30:15.83 shared-libraries-win32.cc
30:16.98 Unified_cpp_accessible_base1.cpp
30:16.99 accessible_base.lib.desc
30:17.74 HandlerProvider.cpp
30:17.74 builds\opt\dist\include\mozilla/a11y/HandlerProvider.h(63): error C2061: syntax error: identifier 'IARelationData'
30:17.74 builds\opt\dist\include\mozilla/a11y/HandlerProvider.h(93): error C2061: syntax error: identifier 'IARelationData'
30:17.74 builds\opt\dist\include\mozilla/a11y/HandlerProvider.h(63): error C3668: 'mozilla::a11y::HandlerProvider::get_RelationsInfo': method with override specifier 'override' did not override any base class methods
30:17.74 mozilla-central/accessible/ipc/win/HandlerProvider.cpp(666): error C2065: 'IARelationData': undeclared identifier
30:17.74 mozilla-central/accessible/ipc/win/HandlerProvider.cpp(666): error C2065: 'aRelations': undeclared identifier
30:17.74 mozilla-central/accessible/ipc/win/HandlerProvider.cpp(667): error C2062: type 'long' unexpected
30:17.74 mozilla-central/accessible/ipc/win/HandlerProvider.cpp(669): error C2143: syntax error: missing ';' before '{'
30:17.74 mozilla-central/accessible/ipc/win/HandlerProvider.cpp(669): error C2447: '{': missing function header (old-style formal list?)
30:17.74 mozilla-central/accessible/ipc/win/HandlerProvider.cpp(713): error C2065: 'IARelationData': undeclared identifier
30:17.74 mozilla-central/accessible/ipc/win/HandlerProvider.cpp(713): error C2065: 'aRelations': undeclared identifier
30:17.74 mozilla-central/accessible/ipc/win/HandlerProvider.cpp(714): error C2062: type 'long' unexpected
30:17.74 mozilla-central/accessible/ipc/win/HandlerProvider.cpp(715): error C2143: syntax error: missing ';' before '{'
30:17.74 mozilla-central/accessible/ipc/win/HandlerProvider.cpp(715): error C2447: '{': missing function header (old-style formal list?)
30:17.74 mozmake.EXE[4]: *** [mozilla-central/config/rules.mk:1049: HandlerProvider.obj] Error 2

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1435696 - include oleacc.h so the compiler knows what IARelationData is,

Review commit: https://reviewboard.mozilla.org/r/217830/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217830/

Comment 2

[:Gijs (he/him)]

Not sure the attached patch is the best fix, but it seems to wfm, at least.

Comment 3

[Marco Zehe (:MarcoZ)]

We were speculating whether the fix for bug 1431264 needed a clobber or not. Looks like it does. :(

Comment 4

[:Gijs (he/him)]

Apparently this is really bug 1420119.