1435701 - [TSF] Add new Japanese IME GUIDs and make TSFStaticSink::IsATOKActiveInternal() aware of ATOK Passport

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

TIP name of ATOK Passport (subscription license) is just "ATOK", not "ATOK " + release year. So, we need to update TSFStaticSink::IsATOKActiveInternal().

Additionally, we should have GUIDs of new Japanese IMEs with comment.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1435701 - Make TSFStaticSink::IsATOKActiveInternal() aware of ATOK Passport

TIP name of ATOK Passport's ATOK 31.1.2 is just "ATOK", not "ATOK " + release
year.  Therefore, TSFStaticSink::IsATOKActiveInternal() returns false when
new ATOK is active.  This patch updates it.

Additionally, this patch adds GUID list of new Japanese TIPs with comment.
They should be useful when somebody needs to add hack for them.

Review commit: https://reviewboard.mozilla.org/r/217864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217864/

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 8948393 [details]
Bug 1435701 - Make TSFStaticSink::IsATOKActiveInternal() aware of ATOK Passport

https://reviewboard.mozilla.org/r/217864/#review223850

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b7a2a9bc5a9
Make TSFStaticSink::IsATOKActiveInternal() aware of ATOK Passport r=m_kato

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8948393 [details]
Bug 1435701 - Make TSFStaticSink::IsATOKActiveInternal() aware of ATOK Passport

Approval Request Comment
[Feature/Bug causing the regression]:
Adding new version of ATOK (Japanese 3rd party's IME) to whitelist to enable hack against bug of Windows.

[User impact if declined]:
New ATOK's user may see candidate window, suggest window and/or navi-bar of ATOK at odd position.  I still don't meet such symptom yet. However, our code assumed that our hack for ATOK is enabled even with new ATOK.

[Is this code covered by automated tests?]:
No.

[Has the fix been verified in Nightly?]:
Not yet, but I tested with patched build and I don't see any new regression.

[Needs manual test from QE? If yes, steps to reproduce]: 
No. ATOK is proprietary 3rd party's IME and it's difficult to test with it without enough Japanese language skill. 

[List of other uplifts needed for the feature/fix]:
No.

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
Current code assumes that our hack for ATOK is also enabled with new ATOK (released 1st, Feb). However, the internal naming rule becomes different. Therefore, this just includes the new name to check if active IME is ATOK.

[String changes made/needed]:
No.

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4b7a2a9bc5a9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8948393 [details]
Bug 1435701 - Make TSFStaticSink::IsATOKActiveInternal() aware of ATOK Passport

Small fix to properly recognize newer versions of ATOK. Approved for 59b8.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/805fb5f7db8f