[TSF] Add new Japanese IME GUIDs and make TSFStaticSink::IsATOKActiveInternal() aware of ATOK Passport

RESOLVED FIXED in Firefox 59

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod})

Trunk
mozilla60
All
Windows
Points:
---

Firefox Tracking Flags

(firefox59 fixed, firefox60 fixed)

Details

Attachments

(1 attachment)

TIP name of ATOK Passport (subscription license) is just "ATOK", not "ATOK " + release year. So, we need to update TSFStaticSink::IsATOKActiveInternal().

Additionally, we should have GUIDs of new Japanese IMEs with comment.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8948393 [details]
Bug 1435701 - Make TSFStaticSink::IsATOKActiveInternal() aware of ATOK Passport

https://reviewboard.mozilla.org/r/217864/#review223850
Attachment #8948393 - Flags: review?(m_kato) → review+

Comment 3

a year ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/4b7a2a9bc5a9
Make TSFStaticSink::IsATOKActiveInternal() aware of ATOK Passport r=m_kato
Comment on attachment 8948393 [details]
Bug 1435701 - Make TSFStaticSink::IsATOKActiveInternal() aware of ATOK Passport

Approval Request Comment
[Feature/Bug causing the regression]:
Adding new version of ATOK (Japanese 3rd party's IME) to whitelist to enable hack against bug of Windows.

[User impact if declined]:
New ATOK's user may see candidate window, suggest window and/or navi-bar of ATOK at odd position.  I still don't meet such symptom yet. However, our code assumed that our hack for ATOK is enabled even with new ATOK.

[Is this code covered by automated tests?]:
No.

[Has the fix been verified in Nightly?]:
Not yet, but I tested with patched build and I don't see any new regression.

[Needs manual test from QE? If yes, steps to reproduce]: 
No. ATOK is proprietary 3rd party's IME and it's difficult to test with it without enough Japanese language skill. 

[List of other uplifts needed for the feature/fix]:
No.

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
Current code assumes that our hack for ATOK is also enabled with new ATOK (released 1st, Feb). However, the internal naming rule becomes different. Therefore, this just includes the new name to check if active IME is ATOK.

[String changes made/needed]:
No.
Attachment #8948393 - Flags: approval-mozilla-beta?

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4b7a2a9bc5a9
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Comment on attachment 8948393 [details]
Bug 1435701 - Make TSFStaticSink::IsATOKActiveInternal() aware of ATOK Passport

Small fix to properly recognize newer versions of ATOK. Approved for 59b8.
Attachment #8948393 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.