Closed
Bug 1435708
Opened 6 years ago
Closed 6 years ago
use mozilla::HashString in security/manager/ssl/
Categories
(Core :: Security, enhancement)
Core
Security
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
2.84 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
Using HashString is a little more explicit than PLDHashTable::HashStringKey and brings us closer to the day where we can delete the latter entirely.
|
Assignee | |
Comment 1•6 years ago
|
||
It's not a super-big difference, but at least this way we know that there's one known-good hashing thing (mozilla::HashString), rather than having to go and verify that PLDHashTable::HashStringKey does something smart.
Attachment #8948373 -
Flags: review?(dkeeler)
Comment on attachment 8948373 [details] [diff] [review] use mozilla::HashString in security/manager/ssl/ Review of attachment 8948373 [details] [diff] [review]: ----------------------------------------------------------------- Ok, sounds good.
Attachment #8948373 -
Flags: review?(dkeeler) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6138707451a use mozilla::HashString in security/manager/ssl/; r=keeler
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e6138707451a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•