1435709 - Can't play OGG video on LG G4 devices

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Sorina Florean [:sflorean]]

Attachment: Screenshot_2018-02-05-13-37-53.png

Environment: 
Device: LG G4 (Android 5.1), LG G4 (Android 6.0.1);
Build: Nightly 60.0a1 (2018-02-04);

Steps to reproduce:
1. Go to http://techslides.com/demos/sample-videos/small.ogv or https://lachy.id.au/dev/markup/examples/video/001.html
2. Play the OGG file. 

Expected result:
The video starts playing without issues.

Actual result:
The video can't be played. A message is displayed "Video can't be played because the file is corrupt".

Notes: reproducible only on LG devices.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

jya: can you folks investigate?

Comment 2

[Ralph Giles (:rillian)]

I wonder if LG has just dropped Theora decoder support.

Comment 3

[Jean-Yves Avenard [:jya]]

For this error to occur, it would mean that LG is reporting support for Theora but in fact doesn't
https://searchfox.org/mozilla-central/source/dom/media/platforms/android/AndroidDecoderModule.cpp#107

Seeing that I doubt there are any HW accelerated theora decoder out there, should we just always use the software one like we've done for opus and others ?
https://searchfox.org/mozilla-central/source/dom/media/platforms/android/AndroidDecoderModule.cpp#97

Ralph, your call...

Comment 4

[Ralph Giles (:rillian)]

Lumping it in with the free audio codecs makes sense to me. Theora isn't on Android's list of supported codecs, so we shouldn't expect a platform decoder in any case.

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1435709 - Don't attempt to use stagefright to decode theora.

Review commit: https://reviewboard.mozilla.org/r/224598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224598/

Comment 6

[Paul Adenot (:padenot)]

Comment on attachment 8955420 [details]
Bug 1435709 - Don't attempt to use stagefright to decode theora.

https://reviewboard.mozilla.org/r/224598/#review230602

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26ae1fdb017c
Don't attempt to use stagefright to decode theora. r=padenot

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/26ae1fdb017c

Comment 9

[Ralph Giles (:rillian)]

Thanks for fixing!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This sounds like something we should try to get uplifted to 59 still. Can you please request release approval on this?

Comment 11

[Jean-Yves Avenard [:jya]]

Comment on attachment 8955420 [details]
Bug 1435709 - Don't attempt to use stagefright to decode theora.

Approval Request Comment
[Feature/Bug causing the regression]: unknown
[User impact if declined]: Some android devices won't be able to play Ogg file with Theora track
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no, however the fix is so trivial, it cannot not work
[Needs manual test from QE? If yes, steps to reproduce]: Use one of the mentioned device
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: We already bypass the android's system decoder for many codecs. Theora isn't a codec officially supported, if it ever worked before it was an accident.
[String changes made/needed]: none

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8955420 [details]
Bug 1435709 - Don't attempt to use stagefright to decode theora.

Approved for Fennec 59b15. Sorina, please verify that this is fixed when you get a chance.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d06407068b75 (FIREFOX_59b_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-release/rev/3a2bd089c278

Comment 14

[Sorina Florean [:sflorean]]

Verified as fixed on latest Nightly build (03/05). The video is playing. 
Device: LG G4 (Android 5.1), LG G4 (Android 6.0.1). 
Keeping the needinfo for checking 59b15.

Comment 15

[Ralph Giles (:rillian)]

Thanks for verifying!

Comment 16

[Oana Horvath [:ohorvath]]

Verified as fixed on Beta 59b15.
Devices: LG G4 (Android 5.1), LG G4 (Android 6.0.1).

Comment 17

[Oana Horvath [:ohorvath]]

Also verified on RC 59.0.