Closed Bug 1435791 Opened 2 years ago Closed 2 years ago

Remove webapps actor front

Categories

(DevTools Graveyard :: WebIDE, enhancement, P3)

enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Assignee: nobody → poirot.alex
Attachment #8948470 - Flags: review?(jdescottes)
Comment on attachment 8948470 [details]
Bug 1435791 - Remove webapps actor front.

https://reviewboard.mozilla.org/r/217892/#review223770

Thanks for the cleanup Alex!

::: devtools/client/webide/modules/app-manager.js
(Diff revision 3)
>        return new Map();
>      }
>    },
>  
> -  onInstallProgress: function (event, details) {
> -    this.update("install-progress", details);

We can remove the handler for install-progress at https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/devtools/client/webide/content/webide.js#183

(+ a comment at https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/devtools/client/webide/modules/app-manager.js#96-99 )

::: devtools/shared/apps/moz.build
(Diff revision 3)
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  DevToolsModules(
> -    'app-actor-front.js',

This file is still required in devtools/client/webide/content/monitor.js (https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/devtools/client/webide/content/monitor.js#9)

I assume the monitor part of WebIDE was ffos only and is broken anyway? https://developer.mozilla.org/en-US/docs/Tools/WebIDE/Monitor

Do we have a bug to remove the monitor screen?
Attachment #8948470 - Flags: review?(jdescottes) → review+
(In reply to Julian Descottes [:jdescottes][:julian] from comment #4)
> >  DevToolsModules(
> > -    'app-actor-front.js',
> 
> This file is still required in devtools/client/webide/content/monitor.js
> (https://searchfox.org/mozilla-central/rev/
> f80722d4f3bfb722c5ec53880c4a7efb71285676/devtools/client/webide/content/
> monitor.js#9)
> 
> I assume the monitor part of WebIDE was ffos only and is broken anyway?
> https://developer.mozilla.org/en-US/docs/Tools/WebIDE/Monitor

Oh yes, I saw the monitor and then forgot about it.
Yes, it is fxos specific and only worked with webapps actor.
It should be removed as well as it throws when you try using it:
JavaScript error: resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js, line 608: Error: 'getAll' request packet has no destination.
  (because webapps actor no longer exists)

> Do we have a bug to remove the monitor screen?

I'll remove it in this bug, in a dedicated changeset.
(In reply to Julian Descottes [:jdescottes][:julian] from comment #4)
> I assume the monitor part of WebIDE was ffos only and is broken anyway?
> https://developer.mozilla.org/en-US/docs/Tools/WebIDE/Monitor

I added a deprecated note in this MDN page.
Comment on attachment 8948630 [details]
Bug 1435791 - Remove WebIDE monitor panel.

https://reviewboard.mozilla.org/r/218042/#review223852

Nice! Two things:
- remaining entities in devtools/client/locales/en-US/webide.dtd (https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/devtools/client/locales/en-US/webide.dtd#39-40)
- I think we an remove the monitor actor as well? (https://searchfox.org/mozilla-central/source/devtools/server/actors/monitor.js)
Attachment #8948630 - Flags: review?(jdescottes)
Comment on attachment 8948630 [details]
Bug 1435791 - Remove WebIDE monitor panel.

https://reviewboard.mozilla.org/r/218042/#review223852

s/an remove/can remove
(In reply to Julian Descottes [:jdescottes][:julian] from comment #9)
> - I think we an remove the monitor actor as well?
> (https://searchfox.org/mozilla-central/source/devtools/server/actors/monitor.
> js)

Oh I didn't realized it had its own actor, yes we can remove it as well.
Comment on attachment 8948630 [details]
Bug 1435791 - Remove WebIDE monitor panel.

https://reviewboard.mozilla.org/r/218042/#review223872

::: devtools/client/locales/en-US/webide.dtd
(Diff revision 2)
>  <!ENTITY devicesetting_newtext "Setting value">
>  <!ENTITY devicesetting_addnew "Add new setting">
>  
> -<!-- Monitor -->
> -<!ENTITY monitor_title "Monitor">
> -<!ENTITY monitor_help "Help">

remove runtimeMenu_showMonitor_label and runtimeMenu_showMonitor_accesskey in the same file
Attachment #8948630 - Flags: review?(jdescottes) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s db957540889e73276a79bc9aa1d288c3ae23a650 -d df6d2c3ee671: rebasing 446006:db957540889e "Bug 1435791 - Remove WebIDE monitor panel. r=jdescottes"
rebasing 446007:1d75df48223d "Bug 1435791 - Remove webapps actor front. r=jdescottes" (tip)
local [dest] changed devtools/shared/apps/app-actor-front.js which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
unresolved conflicts (see hg resolve, then hg rebase --continue)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 837020febe62ed376a82dfd24e5fd69f9f7e3b6c -d 051937e16f04: rebasing 446140:837020febe62 "Bug 1435791 - Remove WebIDE monitor panel. r=jdescottes"
local [dest] changed devtools/client/webide/content/monitor.js which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
merging devtools/client/webide/content/webide.js
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d7cea225c57
Remove WebIDE monitor panel. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/88c8ba0ee51d
Remove webapps actor front. r=jdescottes
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4fbc72f0615e
Remove WebIDE monitor panel. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/c0b74e3ec30a
Remove webapps actor front. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/4fbc72f0615e
https://hg.mozilla.org/mozilla-central/rev/c0b74e3ec30a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Flags: needinfo?(poirot.alex)
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.