Closed Bug 1435820 Opened 4 years ago Closed 4 years ago

[mozprocess] Remove unused C implemenation of proclaunch and all its support files

Categories

(Testing :: Mozbase, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

I would like to clean-up the current mozprocess unit tests to allow us an easier addition of running the tests on Windows, and re-enabling them for OS X.

1) The disabled unit test `test_mozprocess.py`(done ages ago via bug 877864) seems to be unnecessary those days. It is also the only test which is actually using the proclauncer as implemented in C. Everything else is using Python to launch the wanted processes for testing mozprocess. As such lets get this test and all unused files removed.

2) Helper modules should be placed into a sub folder (package). Same for ini files.
Oh, I missed the iniparser which we also want to remove. The Python implementation is using ConfigParser for that.
With https://github.com/mozilla/mozbase-deprecated/commit/a49d775725c4bd5a97492f1728428bdac62aea7f we landed the new Python implementation of proclaunch and never actually removed the old c implementation.
Status: NEW → ASSIGNED
Depends on: 778267
Summary: [mozprocess] Refactor unit tests → [mozprocess] Remove unused C implemenation of proclaunch and all its support files
Just to note this patch needs a little bit of refactoring due to merge conflicts with the patch from bug 921632 which is not on central yet.
Blocks: 892902
Comment on attachment 8948519 [details]
Bug 1435820 - [mozprocess] Remove unused C implemenation of proclaunch and all its support files.

https://reviewboard.mozilla.org/r/217932/#review223976

Nice cleanup, thanks!
Attachment #8948519 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8948520 [details]
Bug 1435820 - Rename mozprocess unit tests and support files.

https://reviewboard.mozilla.org/r/217934/#review223978

This looks much better!
Attachment #8948520 - Flags: review?(ahalberstadt) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48250e34a17d
[mozprocess] Remove unused C implemenation of proclaunch and all its support files. r=ahal
https://hg.mozilla.org/integration/autoland/rev/828f63e2d52a
Rename mozprocess unit tests and support files. r=ahal
https://hg.mozilla.org/mozilla-central/rev/48250e34a17d
https://hg.mozilla.org/mozilla-central/rev/828f63e2d52a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.