1435820 - [mozprocess] Remove unused C implemenation of proclaunch and all its support files

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I would like to clean-up the current mozprocess unit tests to allow us an easier addition of running the tests on Windows, and re-enabling them for OS X.

1) The disabled unit test `test_mozprocess.py`(done ages ago via bug 877864) seems to be unnecessary those days. It is also the only test which is actually using the proclauncer as implemented in C. Everything else is using Python to launch the wanted processes for testing mozprocess. As such lets get this test and all unused files removed.

2) Helper modules should be placed into a sub folder (package). Same for ini files.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh, I missed the iniparser which we also want to remove. The Python implementation is using ConfigParser for that.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With https://github.com/mozilla/mozbase-deprecated/commit/a49d775725c4bd5a97492f1728428bdac62aea7f we landed the new Python implementation of proclaunch and never actually removed the old c implementation.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1435820 - [mozprocess] Remove unused C implemenation of proclaunch and all its support files.

Only test_mozprocess.py was still using the C implementation but is
disabled since ages.

Given that the proclaunch script as written in Python replaced the
C implemenation lets remove all the old unused code.

Review commit: https://reviewboard.mozilla.org/r/217932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217932/

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1435820 - Rename mozprocess unit tests and support files.

Review commit: https://reviewboard.mozilla.org/r/217934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217934/

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8948520 [details]
Bug 1435820 - Rename mozprocess unit tests and support files.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217934/diff/1-2/

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Try push is here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d903b42d6f2fa18fac7e7109bf03146d02f166d

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Just to note this patch needs a little bit of refactoring due to merge conflicts with the patch from bug 921632 which is not on central yet.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8948519 [details]
Bug 1435820 - [mozprocess] Remove unused C implemenation of proclaunch and all its support files.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217932/diff/1-2/

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8948520 [details]
Bug 1435820 - Rename mozprocess unit tests and support files.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217934/diff/2-3/

Comment 10

[Andrew Halberstadt [:ahal]]

Comment on attachment 8948519 [details]
Bug 1435820 - [mozprocess] Remove unused C implemenation of proclaunch and all its support files.

https://reviewboard.mozilla.org/r/217932/#review223976

Nice cleanup, thanks!

Comment 11

[Andrew Halberstadt [:ahal]]

Comment on attachment 8948520 [details]
Bug 1435820 - Rename mozprocess unit tests and support files.

https://reviewboard.mozilla.org/r/217934/#review223978

This looks much better!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48250e34a17d
[mozprocess] Remove unused C implemenation of proclaunch and all its support files. r=ahal
https://hg.mozilla.org/integration/autoland/rev/828f63e2d52a
Rename mozprocess unit tests and support files. r=ahal

Comment 13

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/48250e34a17d
https://hg.mozilla.org/mozilla-central/rev/828f63e2d52a