Closed Bug 143587 Opened 18 years ago Closed 18 years ago

rdf/build should require unicharutil

Categories

(Core Graveyard :: Embedding: APIs, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mcafee, Assigned: mcafee)

References

Details

Attachments

(1 file, 1 obsolete file)

When building rdf/build, I get a "missing libunicharutil_s.a"
link error because this module doesn't require the unicharutil
module.  I think it should, patch coming up.
Blocks: 143524
Comment on attachment 83153 [details] [diff] [review]
Add unicharutil to rdf/build REQUIRES

Hrm. Is this how we want to handle these virtual deps?	Those deps will just be
slated for removal whenever alecf/jag's requires script is run.  I think that
this would be better handled by the partial orders list that alecf mentioned in
bug 143399. You should at least add a note stating why that particular
non-compile-time dependency is needed so that it isn't removed.
Attachment #83153 - Flags: needs-work+
wait a sec, that's right! rdf/build is part of the "rdf" module, and the RDF
module REQUIRES unicharutil, so if leaf-ordered builds are working as
advertised, then this library should already be built. I'm not sure how adding
REQUIRES would actually fix the problem..
rdf/base/src/Makefile.in requires unicharutil.  rdf, however, appears to be
separate from rdfbase if I'm reading all.dot correctly.  Why do we have rdfbase
as  a separate entry from rdf? I can understand having rdfutil as separate since
librdfutil_s.a is used by several other modules but rdfbase & rdf should be
joined at the hip.


 
probably just an oversight. Good spot!
Attachment #83153 - Attachment is obsolete: true
Comment on attachment 83414 [details] [diff] [review]
rename rdfbase to rdf, ignore previous patch

sr=alecf
Attachment #83414 - Flags: superreview+
Comment on attachment 83414 [details] [diff] [review]
rename rdfbase to rdf, ignore previous patch

r=cls

does rdf/chrome/src need to  change as well?
Attachment #83414 - Flags: review+
fixed this for rdf/chrome/src also.  marking fixed.  will check in new all.dot
to reflect this change.
ugh, the one in chrome/src should be "chrome" not "rdf" 
(in fact the whole chrome subdirectory doesn't really belong under the "rdf"
directory, but that's another issue)
oops.  I will fix this when the tree opens.
fixed chrome module part.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
To ashish for bug verification
QA Contact: mdunn → ashishbhatt
Verified
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.