Closed
Bug 1435871
Opened 3 years ago
Closed 3 years ago
Implement a basic tab-modal dialog container for Payment Request
Categories
(Firefox :: WebPayments UI, enhancement, P1)
Firefox
WebPayments UI
Tracking
()
VERIFIED
FIXED
Firefox 64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | verified |
People
(Reporter: MattN, Assigned: MattN)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Whiteboard: [webpayments])
User Story
* Basic implementation with iframe in tabbrowser stack.
* Ideally the dialog should only be rendered once the dialog contents notify that they are ready (e.g. if they need to do async DB queries) so that we don't render a partial layout and then flicker to a finished one.
* Toggle visibility upon tab switch
* Should the user be able to interact with the website under the dialog?
* Basic tests
Potential API:
```js
let dialog = yield browser.openDialog("my-dialog.xhtml");
dialog.close();
```
my-dialog.xhtml could perhaps dispatch an Event when it's ready to be shown.
Attachments
(3 files)
For this initial bug, we'll just try to get the basics of an API to show a dialog (represented by a frame with an HTML document) associated with a tab. We should figure out if the API should be for a standalone <browser> too or only ones inside a <tabbrowser>.
|
Assignee | |
Updated•3 years ago
|
User Story: (updated)
|
|
Assignee | |
Updated•3 years ago
|
User Story: (updated)
|
||
Updated•3 years ago
|
Priority: P3 → P2
Whiteboard: [webpayments]
|
|
||
Updated•3 years ago
|
Priority: P2 → P3
Whiteboard: [webpayments] → [webpayments-reserve]
|
||
Updated•3 years ago
|
Product: Toolkit → Firefox
|
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: P3 → P1
QA Contact: hani.yacoub
Whiteboard: [webpayments-reserve] → [webpayments]
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
Attachment #9014941 -
Attachment description: Bug 1435871 - Prototype: Implement a basic tab-modal dialog container for Payment Request → Bug 1435871 - Implement a basic tab-modal dialog container for Payment Request
|
|
||
Updated•3 years ago
|
Attachment #9014941 -
Attachment description: Bug 1435871 - Implement a basic tab-modal dialog container for Payment Request → Bug 1435871 - Implement a basic tab-modal dialog container for Payment Request. r?jaws
|
|
||
Updated•3 years ago
|
Attachment #9016012 -
Attachment description: Bug 1435871 - Back out changeset 3f6664786e85 (Bug 1435871) since it's for a windowed dialog. r?jaws → Bug 1435871 - Back out changeset 3f6664786e85 (Bug 1470584) since it's for a windowed dialog. r?jaws
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
|
Assignee | |
Comment 4•3 years ago
|
||
I've now completed the tests and everything is ready for review. I addressed everything in the user story except: > Handle the interaction with other in-content dialogs like `alert/confirm` and our onbeforeunload dialog when the user tries to close the tab while the PR dialog is showing. as I noticed that Chrome doesn't handle this, it's probably not common, and I don't think it would significantly change the architecture. I filed bug 1498447 for it. We can see how this design works for Payment Request before making it more general (bug 1319984).
User Story: (updated)
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/afdc3066f12c Back out changeset 3f6664786e85 (Bug 1470584) since it's for a windowed dialog. r=jaws https://hg.mozilla.org/integration/autoland/rev/29777ddd9def Implement a basic tab-modal dialog container for Payment Request. r=jaws https://hg.mozilla.org/integration/autoland/rev/8eab3320b8c5 Open prefs from Payment Request in a tab. r=jaws
|
||
Comment 6•3 years ago
|
||
Backed out 3 changesets (bug 1435871) for mochitest crashes. CLOSED TREE Log: https://treeherder.mozilla.org/logviewer.html#?job_id=206199879&repo=autoland&lineNumber=8889 task 2018-10-17T19:56:23.096Z] 19:56:23 INFO - TEST-START | dom/payments/test/test_abortPayment.html [task 2018-10-17T19:56:24.250Z] 19:56:24 INFO - GECKO(6421) | JavaScript error: jar:file:///builds/worker/workspace/build/application/firefox/browser/omni.ja!/components/paymentUIService.js, line 173: TypeError: browser.parentElement.querySelector(...) is null; can't access its "remove" property [task 2018-10-17T19:56:24.307Z] 19:56:24 INFO - GECKO(6421) | ExceptionHandler::GenerateDump cloned child 6617 [task 2018-10-17T19:56:24.308Z] 19:56:24 INFO - GECKO(6421) | ExceptionHandler::SendContinueSignalToChild sent continue signal to child [task 2018-10-17T19:56:24.308Z] 19:56:24 INFO - GECKO(6421) | ExceptionHandler::WaitForContinueSignal waiting for continue signal... [task 2018-10-17T19:56:24.425Z] 19:56:24 INFO - GECKO(6421) | IPDL protocol error: Handler returned error code! [task 2018-10-17T19:56:24.427Z] 19:56:24 INFO - GECKO(6421) | ###!!! [Parent][DispatchAsyncMessage] Error: PPaymentRequest::Msg_RequestPayment Processing error: message was deserialized, but the handler returned false (indicating failure) [task 2018-10-17T19:56:24.444Z] 19:56:24 INFO - GECKO(6421) | ###!!! [Parent][MessageChannel] Error: (msgtype=0x190084,name=PBrowser::Msg_Destroy) Channel error: cannot send/recv [task 2018-10-17T19:56:24.502Z] 19:56:24 INFO - GECKO(6421) | A content process crashed and MOZ_CRASHREPORTER_SHUTDOWN is set, shutting down [task 2018-10-17T19:56:24.822Z] 19:56:24 INFO - GECKO(6421) | 1539806184813 Marionette DEBUG Received observer notification xpcom-will-shutdown [task 2018-10-17T19:56:24.824Z] 19:56:24 INFO - GECKO(6421) | 1539806184813 Marionette INFO Stopped listening on port 2828 [task 2018-10-17T19:56:24.825Z] 19:56:24 INFO - GECKO(6421) | 1539806184813 Marionette DEBUG Remote service is inactive [task 2018-10-17T19:56:25.109Z] 19:56:25 INFO - TEST-INFO | Main app process: exit 0 [task 2018-10-17T19:56:25.110Z] 19:56:25 INFO - runtests.py | Application ran for: 0:00:06.188596 [task 2018-10-17T19:56:25.111Z] 19:56:25 INFO - zombiecheck | Reading PID log: /tmp/tmphhLVhqpidlog [task 2018-10-17T19:56:25.112Z] 19:56:25 INFO - ==> process 6421 launched child process 6444 [task 2018-10-17T19:56:25.112Z] 19:56:25 INFO - ==> process 6421 launched child process 6514 [task 2018-10-17T19:56:25.114Z] 19:56:25 INFO - ==> process 6421 launched child process 6541 [task 2018-10-17T19:56:25.114Z] 19:56:25 INFO - ==> process 6421 launched child process 6578 [task 2018-10-17T19:56:25.115Z] 19:56:25 INFO - ==> process 6421 launched child process 6618 [task 2018-10-17T19:56:25.117Z] 19:56:25 INFO - zombiecheck | Checking for orphan process with PID: 6618 [task 2018-10-17T19:56:25.117Z] 19:56:25 INFO - zombiecheck | Checking for orphan process with PID: 6514 [task 2018-10-17T19:56:25.117Z] 19:56:25 INFO - zombiecheck | Checking for orphan process with PID: 6444 [task 2018-10-17T19:56:25.118Z] 19:56:25 INFO - zombiecheck | Checking for orphan process with PID: 6541 [task 2018-10-17T19:56:25.118Z] 19:56:25 INFO - zombiecheck | Checking for orphan process with PID: 6578 [task 2018-10-17T19:56:25.118Z] 19:56:25 INFO - mozcrash Downloading symbols from: https://queue.taskcluster.net/v1/task/SHMj9NjIQbK0ogS5nicSWg/artifacts/public/build/target.crashreporter-symbols.zip [task 2018-10-17T19:56:32.876Z] 19:56:32 INFO - mozcrash Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/tmp9Tp3EH.mozrunner/minidumps/5305682e-22a9-3edf-915f-ae65c93a8960-browser.dmp /tmp/tmpDGcYal [task 2018-10-17T19:56:41.819Z] 19:56:41 INFO - mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/5305682e-22a9-3edf-915f-ae65c93a8960-browser.dmp [task 2018-10-17T19:56:41.970Z] 19:56:41 INFO - PROCESS-CRASH | Main app process exited normally | application crashed [@ google_breakpad::ExceptionHandler::WriteMinidump()] [task 2018-10-17T19:56:41.971Z] 19:56:41 INFO - Crash dump filename: /tmp/tmp9Tp3EH.mozrunner/minidumps/5305682e-22a9-3edf-915f-ae65c93a8960-browser.dmp [task 2018-10-17T19:56:41.971Z] 19:56:41 INFO - Operating system: Linux [task 2018-10-17T19:56:41.972Z] 19:56:41 INFO - 0.0.0 Linux 4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018 x86_64 [task 2018-10-17T19:56:41.972Z] 19:56:41 INFO - CPU: amd64 [task 2018-10-17T19:56:41.973Z] 19:56:41 INFO - family 6 model 62 stepping 4 [task 2018-10-17T19:56:41.973Z] 19:56:41 INFO - 2 CPUs [task 2018-10-17T19:56:41.973Z] 19:56:41 INFO - [task 2018-10-17T19:56:41.974Z] 19:56:41 INFO - GPU: UNKNOWN [task 2018-10-17T19:56:41.975Z] 19:56:41 INFO - [task 2018-10-17T19:56:41.976Z] 19:56:41 INFO - Crash reason: DUMP_REQUESTED [task 2018-10-17T19:56:41.976Z] 19:56:41 INFO - Crash address: 0x7f746cb9b035 [task 2018-10-17T19:56:41.977Z] 19:56:41 INFO - Process uptime: not available [task 2018-10-17T19:56:41.978Z] 19:56:41 INFO - [task 2018-10-17T19:56:41.979Z] 19:56:41 INFO - Thread 0 (crashed) [task 2018-10-17T19:56:41.980Z] 19:56:41 INFO - 0 libxul.so!google_breakpad::ExceptionHandler::WriteMinidump() [exception_handler.cc:4868fc98a7b612a705d306b60f4c89707791f714 : 714 + 0x0] [task 2018-10-17T19:56:41.981Z] 19:56:41 INFO - rax = 0x0000000000000000 rdx = 0x0000000000000000 [task 2018-10-17T19:56:41.982Z] 19:56:41 INFO - rcx = 0x00007f746cb9b014 rbx = 0x0000000000000000 [task 2018-10-17T19:56:41.983Z] 19:56:41 INFO - rsi = 0x0000000000000001 rdi = 0x00007ffea4e95908 [task 2018-10-17T19:56:41.983Z] 19:56:41 INFO - rbp = 0x00007ffea4e95ec0 rsp = 0x00007ffea4e95880 [task 2018-10-17T19:56:41.984Z] 19:56:41 INFO - r8 = 0x0000000000000000 r9 = 0x0000000000000000 [task 2018-10-17T19:56:41.985Z] 19:56:41 INFO - r10 = 0x0000000000000000 r11 = 0x70656378652c3635 [task 2018-10-17T19:56:41.985Z] 19:56:41 INFO - r12 = 0x00007f7479d81140 r13 = 0x000000000000198d [task 2018-10-17T19:56:41.986Z] 19:56:41 INFO - r14 = 0x00007ffea4e95ee0 r15 = 0x00007ffea4e96030 [task 2018-10-17T19:56:41.987Z] 19:56:41 INFO - rip = 0x00007f746cb9b035 [task 2018-10-17T19:56:41.987Z] 19:56:41 INFO - Found by: given as instruction pointer in context [task 2018-10-17T19:56:41.987Z] 19:56:41 INFO - 1 libxul.so!google_breakpad::ExceptionHandler::WriteMinidump(std::string const&, bool (*)(google_breakpad::MinidumpDescriptor const&, void*, bool), void*) [exception_handler.cc:4868fc98a7b612a705d306b60f4c89707791f714 : 684 + 0x8] [task 2018-10-17T19:56:41.988Z] 19:56:41 INFO - rbx = 0x00007ffea4e95ee0 rbp = 0x00007ffea4e96000 [task 2018-10-17T19:56:41.988Z] 19:56:41 INFO - rsp = 0x00007ffea4e95ed0 r12 = 0x00007f7479d81140 [task 2018-10-17T19:56:41.989Z] 19:56:41 INFO - r13 = 0x000000000000198d r14 = 0x00007f746cb95580 [task 2018-10-17T19:56:41.990Z] 19:56:41 INFO - r15 = 0x00007ffea4e96030 rip = 0x00007f746cb9aeed [task 2018-10-17T19:56:41.991Z] 19:56:41 INFO - Found by: call frame info [task 2018-10-17T19:56:41.992Z] 19:56:41 INFO - 2 libxul.so!CrashReporter::CreateMinidumpsAndPair(int, int, nsTSubstring<char> const&, nsIFile*, nsIFile**) [nsExceptionHandler.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 3925 + 0x14] [task 2018-10-17T19:56:41.994Z] 19:56:41 INFO - rbx = 0x00007f74551e47c0 rbp = 0x00007ffea4e96070 [task 2018-10-17T19:56:41.995Z] 19:56:41 INFO - rsp = 0x00007ffea4e96010 r12 = 0x0000000000000000 [task 2018-10-17T19:56:41.996Z] 19:56:41 INFO - r13 = 0x000000000000198d r14 = 0x00007ffea4e96038 [task 2018-10-17T19:56:41.998Z] 19:56:41 INFO - r15 = 0x00007f7479d81140 rip = 0x00007f746cb95969 [task 2018-10-17T19:56:41.999Z] 19:56:41 INFO - Found by: call frame info [task 2018-10-17T19:56:42.000Z] 19:56:42 INFO - 3 libxul.so!bool mozilla::ipc::CrashReporterHost::GenerateMinidumpAndPair<mozilla::dom::ContentParent>(mozilla::dom::ContentParent*, nsIFile*, nsTSubstring<char> const&) [CrashReporterHost.h:4868fc98a7b612a705d306b60f4c89707791f714 : 77 + 0x14] [task 2018-10-17T19:56:42.001Z] 19:56:42 INFO - rbx = 0x00007f7459b8e000 rbp = 0x00007ffea4e960c0 [task 2018-10-17T19:56:42.002Z] 19:56:42 INFO - rsp = 0x00007ffea4e96080 r12 = 0x000000000000198d [task 2018-10-17T19:56:42.004Z] 19:56:42 INFO - r13 = 0x000000000000198d r14 = 0x0000000000000000 [task 2018-10-17T19:56:42.005Z] 19:56:42 INFO - r15 = 0x00007ffea4e96128 rip = 0x00007f746b8b7225 [task 2018-10-17T19:56:42.006Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.008Z] 19:56:42 INFO - 4 libxul.so!mozilla::dom::ContentParent::KillHard(char const*) [ContentParent.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 3370 + 0xa] [task 2018-10-17T19:56:42.009Z] 19:56:42 INFO - rbx = 0x00007ffea4e960d0 rbp = 0x00007ffea4e96170 [task 2018-10-17T19:56:42.010Z] 19:56:42 INFO - rsp = 0x00007ffea4e960d0 r12 = 0x00007f7459bc1000 [task 2018-10-17T19:56:42.011Z] 19:56:42 INFO - r13 = 0x00007f746264bf88 r14 = 0x00007f7456982d0c [task 2018-10-17T19:56:42.013Z] 19:56:42 INFO - r15 = 0x00007f746ec54b9b rip = 0x00007f746b8af890 [task 2018-10-17T19:56:42.014Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.015Z] 19:56:42 INFO - 5 libxul.so!mozilla::ipc::IPCResult::Fail(mozilla::NotNull<mozilla::ipc::IProtocol*>, char const*, char const*) [ProtocolUtils.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 66 + 0x8] [task 2018-10-17T19:56:42.016Z] 19:56:42 INFO - rbx = 0x00007f7455db2a10 rbp = 0x00007ffea4e961c0 [task 2018-10-17T19:56:42.017Z] 19:56:42 INFO - rsp = 0x00007ffea4e96180 r12 = 0x00007f7455db2a10 [task 2018-10-17T19:56:42.019Z] 19:56:42 INFO - r13 = 0x00007f746264bf88 r14 = 0x00007ffea4e96188 [task 2018-10-17T19:56:42.020Z] 19:56:42 INFO - r15 = 0x00007f7455db2a50 rip = 0x00007f7469e53336 [task 2018-10-17T19:56:42.021Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.022Z] 19:56:42 INFO - 6 libxul.so!mozilla::dom::PaymentRequestParent::RecvRequestPayment(mozilla::dom::IPCPaymentActionRequest const&) [PaymentRequestParent.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 86 + 0x16] [task 2018-10-17T19:56:42.024Z] 19:56:42 INFO - rbx = 0x00007ffea4e96301 rbp = 0x00007ffea4e96200 [task 2018-10-17T19:56:42.025Z] 19:56:42 INFO - rsp = 0x00007ffea4e961d0 r12 = 0x00007f7455db2a10 [task 2018-10-17T19:56:42.027Z] 19:56:42 INFO - r13 = 0x00007f746264bf88 r14 = 0x00007ffea4e96210 [task 2018-10-17T19:56:42.028Z] 19:56:42 INFO - r15 = 0x00007f7455db2a50 rip = 0x00007f746ba378a1 [task 2018-10-17T19:56:42.029Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.031Z] 19:56:42 INFO - 7 libxul.so!mozilla::dom::PPaymentRequestParent::OnMessageReceived(IPC::Message const&) [PPaymentRequestParent.cpp: : 237 + 0x10] [task 2018-10-17T19:56:42.032Z] 19:56:42 INFO - rbx = 0x00007ffea4e96300 rbp = 0x00007ffea4e96350 [task 2018-10-17T19:56:42.033Z] 19:56:42 INFO - rsp = 0x00007ffea4e96210 r12 = 0x0000000000000000 [task 2018-10-17T19:56:42.035Z] 19:56:42 INFO - r13 = 0x00007f746264bf88 r14 = 0x00007f7455db2a10 [task 2018-10-17T19:56:42.036Z] 19:56:42 INFO - r15 = 0x00007f746264bf90 rip = 0x00007f7469fa1126 [task 2018-10-17T19:56:42.037Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.038Z] 19:56:42 INFO - 8 libxul.so!mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&) [MessageChannel.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 2248 + 0x9] [task 2018-10-17T19:56:42.040Z] 19:56:42 INFO - rbx = 0x00007f7463b524e0 rbp = 0x00007ffea4e96390 [task 2018-10-17T19:56:42.041Z] 19:56:42 INFO - rsp = 0x00007ffea4e96360 r12 = 0x00007f7463b52400 [task 2018-10-17T19:56:42.042Z] 19:56:42 INFO - r13 = 0x0000000000000000 r14 = 0x00007f746264bf88 [task 2018-10-17T19:56:42.043Z] 19:56:42 INFO - r15 = 0x0000000000000001 rip = 0x00007f7469e509b2 [task 2018-10-17T19:56:42.045Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.046Z] 19:56:42 INFO - 9 libxul.so!mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) [MessageChannel.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 2175 + 0xb] [task 2018-10-17T19:56:42.047Z] 19:56:42 INFO - rbx = 0x00007f7459bae740 rbp = 0x00007ffea4e96420 [task 2018-10-17T19:56:42.049Z] 19:56:42 INFO - rsp = 0x00007ffea4e963a0 r12 = 0x00007f7463b524e0 [task 2018-10-17T19:56:42.050Z] 19:56:42 INFO - r13 = 0x0000000000000000 r14 = 0x00007f746264bf88 [task 2018-10-17T19:56:42.051Z] 19:56:42 INFO - r15 = 0x00000000ffffffff rip = 0x00007f7469e4fbb9 [task 2018-10-17T19:56:42.052Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.054Z] 19:56:42 INFO - 10 libxul.so!mozilla::ipc::MessageChannel::MessageTask::Run() [MessageChannel.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 2045 + 0x8] [task 2018-10-17T19:56:42.055Z] 19:56:42 INFO - rbx = 0x00007f746264bf30 rbp = 0x00007ffea4e96440 [task 2018-10-17T19:56:42.056Z] 19:56:42 INFO - rsp = 0x00007ffea4e96430 r12 = 0x0000000000000001 [task 2018-10-17T19:56:42.057Z] 19:56:42 INFO - r13 = 0x0000000000000000 r14 = 0x00007f7459bae740 [task 2018-10-17T19:56:42.059Z] 19:56:42 INFO - r15 = 0x00007f7478f5edc0 rip = 0x00007f7469e5049e [task 2018-10-17T19:56:42.060Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.062Z] 19:56:42 INFO - 11 libxul.so!nsThread::ProcessNextEvent(bool, bool*) [nsThread.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 1252 + 0x6] [task 2018-10-17T19:56:42.063Z] 19:56:42 INFO - rbx = 0x0000000000000000 rbp = 0x00007ffea4e96970 [task 2018-10-17T19:56:42.064Z] 19:56:42 INFO - rsp = 0x00007ffea4e96450 r12 = 0x0000000000000001 [task 2018-10-17T19:56:42.066Z] 19:56:42 INFO - r13 = 0x0000000000000000 r14 = 0x00007ffea4e96987 [task 2018-10-17T19:56:42.067Z] 19:56:42 INFO - r15 = 0x00007f7478f5edc0 rip = 0x00007f7469a10622 [task 2018-10-17T19:56:42.069Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.070Z] 19:56:42 INFO - 12 libxul.so!NS_ProcessNextEvent(nsIThread*, bool) [nsThreadUtils.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 530 + 0xd] [task 2018-10-17T19:56:42.071Z] 19:56:42 INFO - rbx = 0x0000000000000000 rbp = 0x00007ffea4e96990 [task 2018-10-17T19:56:42.073Z] 19:56:42 INFO - rsp = 0x00007ffea4e96980 r12 = 0x00007f7478fb6c60 [task 2018-10-17T19:56:42.074Z] 19:56:42 INFO - r13 = 0x00007f7478fb6c40 r14 = 0x00007f7478f8e420 [task 2018-10-17T19:56:42.076Z] 19:56:42 INFO - r15 = 0x00007f7478f5edc0 rip = 0x00007f7469a12778 [task 2018-10-17T19:56:42.077Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.079Z] 19:56:42 INFO - 13 libxul.so!mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [MessagePump.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 97 + 0xa] [task 2018-10-17T19:56:42.080Z] 19:56:42 INFO - rbx = 0x0000000000000001 rbp = 0x00007ffea4e969d0 [task 2018-10-17T19:56:42.081Z] 19:56:42 INFO - rsp = 0x00007ffea4e969a0 r12 = 0x00007f7478fb6c60 [task 2018-10-17T19:56:42.083Z] 19:56:42 INFO - r13 = 0x00007f7478fb6c40 r14 = 0x00007f7478f8e420 [task 2018-10-17T19:56:42.084Z] 19:56:42 INFO - r15 = 0x00007f7478f5edc0 rip = 0x00007f7469e52a8e [task 2018-10-17T19:56:42.086Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.087Z] 19:56:42 INFO - 14 libxul.so!MessageLoop::Run() [message_loop.cc:4868fc98a7b612a705d306b60f4c89707791f714 : 325 + 0x8] [task 2018-10-17T19:56:42.088Z] 19:56:42 INFO - rbx = 0x00007f7463be95e0 rbp = 0x00007ffea4e96a00 [task 2018-10-17T19:56:42.089Z] 19:56:42 INFO - rsp = 0x00007ffea4e969e0 r12 = 0x0003001100000000 [task 2018-10-17T19:56:42.091Z] 19:56:42 INFO - r13 = 0x00007ffea4e96c70 r14 = 0x00007f7478f5edc0 [task 2018-10-17T19:56:42.092Z] 19:56:42 INFO - r15 = 0x00007f747a566430 rip = 0x00007f7469e23b8c [task 2018-10-17T19:56:42.093Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.094Z] 19:56:42 INFO - 15 libxul.so!nsBaseAppShell::Run() [nsBaseAppShell.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 158 + 0x8] [task 2018-10-17T19:56:42.096Z] 19:56:42 INFO - rbx = 0x00007f7463be95e0 rbp = 0x00007ffea4e96a20 [task 2018-10-17T19:56:42.097Z] 19:56:42 INFO - rsp = 0x00007ffea4e96a10 r12 = 0x0003001100000000 [task 2018-10-17T19:56:42.098Z] 19:56:42 INFO - r13 = 0x00007ffea4e96c70 r14 = 0x00007f7478f5edc0 [task 2018-10-17T19:56:42.099Z] 19:56:42 INFO - r15 = 0x00007f747a566430 rip = 0x00007f746bada669 [task 2018-10-17T19:56:42.101Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.102Z] 19:56:42 INFO - 16 libxul.so!nsAppStartup::Run() [nsAppStartup.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 290 + 0x6] [task 2018-10-17T19:56:42.103Z] 19:56:42 INFO - rbx = 0x00007f7463b30f60 rbp = 0x00007ffea4e96a40 [task 2018-10-17T19:56:42.105Z] 19:56:42 INFO - rsp = 0x00007ffea4e96a30 r12 = 0x0003001100000000 [task 2018-10-17T19:56:42.106Z] 19:56:42 INFO - r13 = 0x00007ffea4e96c70 r14 = 0x00007ffea4e96a60 [task 2018-10-17T19:56:42.107Z] 19:56:42 INFO - r15 = 0x00007f747a566430 rip = 0x00007f746cb0a2ee [task 2018-10-17T19:56:42.108Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.110Z] 19:56:42 INFO - 17 libxul.so!XREMain::XRE_mainRun() [nsAppRunner.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 4777 + 0x6] [task 2018-10-17T19:56:42.111Z] 19:56:42 INFO - rbx = 0x00007ffea4e96b40 rbp = 0x00007ffea4e96be0 [task 2018-10-17T19:56:42.112Z] 19:56:42 INFO - rsp = 0x00007ffea4e96a50 r12 = 0x0003001100000000 [task 2018-10-17T19:56:42.113Z] 19:56:42 INFO - r13 = 0x00007ffea4e96c70 r14 = 0x00007ffea4e96a60 [task 2018-10-17T19:56:42.115Z] 19:56:42 INFO - r15 = 0x00007f747a566430 rip = 0x00007f746cbb7b80 [task 2018-10-17T19:56:42.116Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.117Z] 19:56:42 INFO - 18 libxul.so!XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [nsAppRunner.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 4922 + 0x8] [task 2018-10-17T19:56:42.118Z] 19:56:42 INFO - rbx = 0x0000000000000000 rbp = 0x00007ffea4e96c60 [task 2018-10-17T19:56:42.120Z] 19:56:42 INFO - rsp = 0x00007ffea4e96bf0 r12 = 0x00007ffea4e96e60 [task 2018-10-17T19:56:42.121Z] 19:56:42 INFO - r13 = 0x00007ffea4e96c70 r14 = 0x00007f7478f951c0 [task 2018-10-17T19:56:42.122Z] 19:56:42 INFO - r15 = 0x0000000000000001 rip = 0x00007f746cbb83e4 [task 2018-10-17T19:56:42.124Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.125Z] 19:56:42 INFO - 19 libxul.so!XRE_main(int, char**, mozilla::BootstrapConfig const&) [nsAppRunner.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 5014 + 0x11] [task 2018-10-17T19:56:42.126Z] 19:56:42 INFO - rbx = 0x00007ffea4e994fb rbp = 0x00007ffea4e96e50 [task 2018-10-17T19:56:42.128Z] 19:56:42 INFO - rsp = 0x00007ffea4e96c70 r12 = 0x0000000000000005 [task 2018-10-17T19:56:42.129Z] 19:56:42 INFO - r13 = 0x00007ffea4e96c70 r14 = 0x00007ffea4e96e60 [task 2018-10-17T19:56:42.130Z] 19:56:42 INFO - r15 = 0x00007ffea4e97f88 rip = 0x00007f746cbb89c9 [task 2018-10-17T19:56:42.131Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.133Z] 19:56:42 INFO - 20 firefox-bin!main [nsBrowserApp.cpp:4868fc98a7b612a705d306b60f4c89707791f714 : 233 + 0x13] [task 2018-10-17T19:56:42.134Z] 19:56:42 INFO - rbx = 0x00007ffea4e994fb rbp = 0x00007ffea4e97ea0 [task 2018-10-17T19:56:42.136Z] 19:56:42 INFO - rsp = 0x00007ffea4e96e60 r12 = 0x0000000000000005 [task 2018-10-17T19:56:42.141Z] 19:56:42 INFO - r13 = 0x000055febe0ab0c4 r14 = 0x00007ffea4e97f88 [task 2018-10-17T19:56:42.143Z] 19:56:42 INFO - r15 = 0x00007ffea4e994fb rip = 0x000055febe073d8c [task 2018-10-17T19:56:42.145Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.147Z] 19:56:42 INFO - 21 libc-2.23.so + 0x20830 [task 2018-10-17T19:56:42.148Z] 19:56:42 INFO - rbx = 0x0000000000000000 rbp = 0x000055febe0aa580 [task 2018-10-17T19:56:42.150Z] 19:56:42 INFO - rsp = 0x00007ffea4e97eb0 r12 = 0x000055febe0738ac [task 2018-10-17T19:56:42.151Z] 19:56:42 INFO - r13 = 0x00007ffea4e97f80 r14 = 0x0000000000000000 [task 2018-10-17T19:56:42.153Z] 19:56:42 INFO - r15 = 0x0000000000000000 rip = 0x00007f7479137830 [task 2018-10-17T19:56:42.154Z] 19:56:42 INFO - Found by: call frame info [task 2018-10-17T19:56:42.156Z] 19:56:42 INFO - 22 firefox-bin + 0x7a70 [task 2018-10-17T19:56:42.157Z] 19:56:42 INFO - rsp = 0x00007ffea4e97ed0 rip = 0x000055febe073a70 [task 2018-10-17T19:56:42.158Z] 19:56:42 INFO - Found by: stack scanning [task 2018-10-17T19:56:42.159Z] 19:56:42 INFO - 23 firefox-bin + 0x78ac [task 2018-10-17T19:56:42.160Z] 19:56:42 INFO - rsp = 0x00007ffea4e97ee8 rip = 0x000055febe0738ac [task 2018-10-17T19:56:42.162Z] 19:56:42 INFO - Found by: stack scanning [task 2018-10-17T19:56:42.164Z] 19:56:42 INFO - 24 firefox-bin + 0x3e570 [task 2018-10-17T19:56:42.165Z] 19:56:42 INFO - rsp = 0x00007ffea4e97f30 rip = 0x000055febe0aa570 [task 2018-10-17T19:56:42.166Z] 19:56:42 INFO - Found by: stack scanning [task 2018-10-17T19:56:42.167Z] 19:56:42 INFO - 25 ld-2.23.so + 0x10ab0 [task 2018-10-17T19:56:42.168Z] 19:56:42 INFO - rsp = 0x00007ffea4e97f38 rip = 0x00007f747a3bbab0 [task 2018-10-17T19:56:42.169Z] 19:56:42 INFO - Found by: stack scanning [task 2018-10-17T19:56:42.170Z] 19:56:42 INFO - 26 ld-2.23.so + 0x107cb [task 2018-10-17T19:56:42.171Z] 19:56:42 INFO - rsp = 0x00007ffea4e97f40 rip = 0x00007f747a3bb7cb [task 2018-10-17T19:56:42.172Z] 19:56:42 INFO - Found by: stack scanning [task 2018-10-17T19:56:42.173Z] 19:56:42 INFO - 27 firefox-bin + 0x78ac [task 2018-10-17T19:56:42.174Z] 19:56:42 INFO - rsp = 0x00007ffea4e97f58 rip = 0x000055febe0738ac [task 2018-10-17T19:56:42.176Z] 19:56:42 INFO - Found by: stack scanning [task 2018-10-17T19:56:42.177Z] 19:56:42 INFO - 28 firefox-bin!_start + 0x29 [task 2018-10-17T19:56:42.178Z] 19:56:42 INFO - rsp = 0x00007ffea4e97f70 rip = 0x000055febe0738d5 [task 2018-10-17T19:56:42.179Z] 19:56:42 INFO - Found by: stack scanning [task 2018-10-17T19:56:42.181Z] 19:56:42 INFO - Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8eab3320b8c5fdda47ceb1c45e59628c7439f76d Backout: https://hg.mozilla.org/integration/autoland/rev/0623ed3cb752851d5f96618b6a5f7c3048b49b60
Flags: needinfo?(MattN+bmo)
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(MattN+bmo)
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/8641e30ebaf4 Back out changeset 3f6664786e85 (Bug 1470584) since it's for a windowed dialog. r=jaws https://hg.mozilla.org/integration/autoland/rev/039f6d65036e Implement a basic tab-modal dialog container for Payment Request. r=jaws https://hg.mozilla.org/integration/autoland/rev/0f7592b662e2 Open prefs from Payment Request in a tab. r=jaws
|
||
Comment 8•3 years ago
|
||
Backed out 2 changesets (Bug 1435871) for multiple browser-chrome failures on payments. Backout: https://hg.mozilla.org/integration/autoland/rev/ad81b437f8604c61701ae3a3112b8490577308eb Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=0f7592b662e27238b8ebc442fa755e5e891cdef9&selectedJob=206564681 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=206564681&repo=autoland&lineNumber=20899 https://treeherder.mozilla.org/logviewer.html#?job_id=206554785&repo=autoland&lineNumber=21534 https://treeherder.mozilla.org/logviewer.html#?job_id=206558527&repo=autoland&lineNumber=20620 https://treeherder.mozilla.org/logviewer.html#?job_id=206564685&repo=autoland&lineNumber=19617 https://treeherder.mozilla.org/logviewer.html#?job_id=206564690&repo=autoland&lineNumber=9364
Flags: needinfo?(MattN+bmo)
|
|
||
Comment 9•3 years ago
|
||
I've also backed out the other changeset: 8641e30ebaf4
|
||
Comment 10•3 years ago
|
||
Backout by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1030155f208e Backed out changeset 8641e30ebaf4 for multiple browser-chrome failures on payments. CLOSED TREE
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(MattN+bmo)
|
|
||
Comment 11•3 years ago
|
||
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/24a03346eaf5 Back out changeset 3f6664786e85 (Bug 1470584) since it's for a windowed dialog. r=jaws https://hg.mozilla.org/integration/autoland/rev/a1db0baedde0 Implement a basic tab-modal dialog container for Payment Request. r=jaws https://hg.mozilla.org/integration/autoland/rev/d0f1450799b5 Open prefs from Payment Request in a tab. r=jaws
|
||
Comment 12•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/24a03346eaf5 https://hg.mozilla.org/mozilla-central/rev/a1db0baedde0 https://hg.mozilla.org/mozilla-central/rev/d0f1450799b5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
|
||
Comment 13•3 years ago
|
||
Verified - Fixed on the latest Nightly 65.0a1 (2018-10-23) on Windows 7/10, Mac OS 10.13 and Ubuntu 16.04. The about:preferences will be opened in a new tab with the focus on Forms&Autofill. The user can navigate to other tabs while Payment Request is opened.
You need to log in
before you can comment on or make changes to this bug.
Description
•