1435895 - Refactor tests to remove JSON encoding and content-type from tests that don't exercise it

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement)

Description

[Māris Fogels [:mars] (please needinfo)]

Many of our API tests have extra calls to json.dumps() and content_type='application/json'.  For example:

    response = client.post(
        '/landings',
        data=json.dumps({
            'revision_id': 'D1',
            'diff_id': diff_id
        }),
        headers=auth0_mock.mock_headers,
        content_type='application/json'
    )

To increase test readability we should try to include only lines in the tests that describe the behaviour we want to test.  Since all calls to the API are JSON-encoded the calls to json.dumps() and content_type can be removed without hiding what the test does.

Flask 0.13 (unreleased at the time of writing) has a 'json=' keyword argument to client.post() that removes the extra lines.

Comment 1

[Phabricator Automation]

Attachment: tests: add json-enabled test client

Comment 2

[Phabricator Automation]

Comment on attachment 8948550 [details]
tests: add json-enabled test client

Steven MacLeod [:smacleod] has approved the revision.

https://phabricator.services.mozilla.com/D552