Closed
Bug 1435924
Opened 6 years ago
Closed 6 years ago
Remove nsSubstring.h
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
Details
Attachments
(2 files)
|
1.62 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
|
1.19 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
nsSubstring.h just includes nsAString.h, we can remove it and use nsAString.h where appropriate. :m_kato tried this 6 years ago in bug 737400 and it was rejected due to nsSubstring being "the preferred name for the base string class." I think the ship has sailed on that, we only us nsAC?String now for our interfaces and nothing is actually including 'nsSubstring.h' outside of xpcom/string.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8948594 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #8948595 -
Flags: review?(dbaron)
Attachment #8948594 -
Flags: review?(dbaron) → review+
Attachment #8948595 -
Flags: review?(dbaron) → review+
Pushed by erahm@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e945fa4f3c1f Part 1: Switch from nsSubstring.h to nsAString.h. r=dbaron https://hg.mozilla.org/integration/mozilla-inbound/rev/352ef85382ea Part 2: Remove nsSubstring.h. r=dbaron
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e945fa4f3c1f https://hg.mozilla.org/mozilla-central/rev/352ef85382ea
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•3 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•