1435943 - Tweak Preferences::GetType() and nsPrefBranch::GetPrefType()

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement)

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1435943 - Tweak Preferences::GetType() and nsPrefBranch::GetPrefType().

This patch rearranges these functions so that nsPrefBranch::GetPrefType() calls
into Preferences::GetType(), because all other nsPrefBranch methods depend on
Preferences methods.

The patch also removes the `aKind` argument from GetType(), because it has no
effect -- a pref only has one type, regardless of whether it has a default
value, a user value, or both.

Review commit: https://reviewboard.mozilla.org/r/218040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218040/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8948619 [details]
Bug 1435943 - Tweak Preferences::GetType() and nsPrefBranch::GetPrefType().

https://reviewboard.mozilla.org/r/218040/#review223832

::: modules/libpref/Preferences.cpp:4168
(Diff revision 1)
> +
> +    case PrefType::Bool:
> +      return PREF_BOOL;
> +
> +    default:
> +      MOZ_CRASH();

maybe MOZ_ASSERT_UNREACHABLE?

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1043ecc316e5cb616e58521e2d36d4729108704
Bug 1435943 - Tweak Preferences::GetType() and nsPrefBranch::GetPrefType(). r=glandium

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d1043ecc316e