1435962 - mozilla::net::nsHttpConnectionMgr::Shutdown() blocks the shutdown of other components

Status: RESOLVED DUPLICATE of bug 1633342

(Core :: Networking, defect, P3)

Description

[Andrea Marchesini [:baku]]

https://crash-stats.mozilla.com/report/index/83089e4b-77e7-4920-ae56-16d960180206#allthreads and
https://crash-stats.mozilla.com/report/index/a910bdd8-a605-4444-a2a6-d4d4f0180206#allthreads and
https://crash-stats.mozilla.com/report/index/73db45ac-e05c-4441-8a8f-1b5b00180206#allthreads

mozilla::net::nsHttpConnectionMgr::Shutdown() spins the event loop when xpcom-shutdown notification is received, but this spinning is not terminated and other components do not receive the same notification. This means that they don't start the shutdown procedure and, eventually, firefox crashes.

Comment 1

[Michal Novotny [:michal]]

I'm not familiar with nsHttpConnectionMgr shutdown process. Patrick, do you have any idea why OnMsgShutdownConfirm was not called?

Comment 3

[Patrick McManus [:mcmanus]]

an informed guess is that the socket transport thread is hung.

this looks like the hanging PR_POLL() issue dragana was chasing forever and I've heard might be a network driver bug.

Comment 4

[Honza Bambas (:mayhemer)]

We definitely already have a bug filed for this and there has been a lot of attempts to find (and fix) the cause.  Don't have the #'s by hand.

Comment 5

[Trevor Skywalker]

Signature report for mozilla::dom::workers::RuntimeService::CrashIfHanging
Showing results from 7 days ago 

Windows 7 	1419 	53.5%
Windows 10 	780 	29.4%
Windows 8.1 	324 	12.2%
OS X 10.13 	40 	1.5%
OS X 10.11 	30 	1.1%
Windows 8 	20 	0.8%
OS X 10.12 	16 	0.6%
Linux 	10 	0.4%
OS X 10.10 	10 	0.4%
OS X 10.9 	2 	0.1%

Firefox 	59.0.1 	1329 	50.7% 	1157
Firefox 	59.0.2 	703 	26.8% 	1048
Thunderbird 	59.0b2 	197 	7.5% 	231
Firefox 	59.0b12	54 	2.1% 	42
Firefox 	59.0b13	61 	2.3% 	41
Firefox 	59.0b11	37 	1.4% 	36
Firefox 	59.0b9 	25 	1.0% 	30
Firefox 	59.0b7 	27 	1.0% 	29
Firefox 	59.0b8 	21 	0.8% 	27

amd64 	1776 	67.0%
x86 	875 	33.0%

Comment 6

[Trevor Skywalker]

Top Crashers for Firefox 59.0.2

9 	1.08% 	new 	mozilla::dom::workers::RuntimeService::CrashIfHanging	704 	683 	20 	1 	694 	0 	2017-11-16 
	
Top Crashers for Firefox 59.0.1

8 	1.06% 	-0.08% 	mozilla::dom::workers::RuntimeService::CrashIfHanging	1328 	1280 	42 	6 	1296 	0 	2017-11-16

Comment 8

[Sylvestre Ledru [:Sylvestre]]

topcrash, updating the severity.

Comment 10

[Wayne Mery (:wsmwk)]

massive 6 fold increase in crashes on 12/13 according to https://crash-stats.mozilla.com/signature/?signature=shutdownhang%20%7C%20mozilla%3A%3ASpinEventLoopUntil<T>%20%7C%20mozilla%3A%3Anet%3A%3AnsHttpConnectionMgr%3A%3AShutdown&date=>%3D2018-09-15T06%3A58%3A27.000Z&date=<2018-12-15T06%3A58%3A27.000Z#graphs 

12/14 still more than double