Closed Bug 1436084 Opened 3 years ago Closed 3 years ago

Audit failing WR reftests

Categories

(Core :: Graphics: WebRender, defect, P1)

Other Branch
defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1429469 +++

Many of these are passing now, but are fuzzy. Because a fails-if annotation will check for zero fuzz, it will treat any fuzzy tests as failing, and therefore the annotation will "pass". However removing the fails-if and replacing it with an appropriate fuzzy-if will also make the test pass, and is more correct.
Here is the try push where I marked everything passing to identify which ones are still actually failing:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d493998982827d31e4a0a8310c5c9b17f5e3c1b
Comment on attachment 8948718 [details]
Bug 1436084 - Mark some reftests as passing with webrender.

https://reviewboard.mozilla.org/r/218110/#review223944
Attachment #8948718 - Flags: review?(jmuizelaar) → review+
Here's a try push based on autoland (includes latest WR update) and with these patches:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d83cc4fe3fa7bbecd1a90ce29597253684b6344
Comment on attachment 8948719 [details]
Bug 1436084 - Update webrender reftest expectations in w3c-css received reftests.

https://reviewboard.mozilla.org/r/218112/#review224022
Attachment #8948719 - Flags: review?(xidorn+moz) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b97c18388c86
Mark some reftests as passing with webrender. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/b12895bb88fe
Update webrender reftest expectations in w3c-css received reftests. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/b97c18388c86
https://hg.mozilla.org/mozilla-central/rev/b12895bb88fe
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.