1436184 - Remove definitions of Ci, Cr, Cc, and Cu from httpd.js and .sjs files

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[Andrew McCreight [:mccr8]]

httpd.js and .sjs files are run on the version of XPCShell in hostutils, so removing Ci etc from them is going to require updating hostutils. Once that is done, a patch can be generated by backout out commit 9deac2849858c676c1eddb25f783b33d94eaab8a from my moz-source-tools directory ( https://github.com/amccreight/moz-source-tools ) and running the decomponents.py script.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1436184 - Remove definitions of Ci, Cr, Cc, and Cu from httpd.js and .sjs files.

Review commit: https://reviewboard.mozilla.org/r/218206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218206/

Comment 2

[Andrew McCreight [:mccr8]]

This is green with the patch in the blocking bug:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=68783190ba22298f6db1be507109d203bcc62534

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8948834 [details]
Bug 1436184 - Remove definitions of Ci, Cr, Cc, and Cu from httpd.js and .sjs files.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218206/diff/1-2/

Comment 4

[Andrew McCreight [:mccr8]]

These changes should all be part of the patch you reviewed already, so it probably doesn't need careful review.

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8948834 [details]
Bug 1436184 - Remove definitions of Ci, Cr, Cc, and Cu from httpd.js and .sjs files.

https://reviewboard.mozilla.org/r/218206/#review224624

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dce5f1c884cc
Remove definitions of Ci, Cr, Cc, and Cu from httpd.js and .sjs files. r=florian

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/dce5f1c884cc