1436193 - Cloud ad is very slow in WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P2)

Description

[Jeff Muizelaar [:jrmuizel]]

https://jrmuizel.github.io/webrender/slow/coulds.html

It looks like we're spending a bunch of time blurring.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

The url should be https://jrmuizel.github.io/webrender/slow/clouds.html

Comment 2

[Glenn Watson [:gw]]

You can assign this one to me, if you like. I imagine we'll want to add image blurs to the list of items we pre-render to the texture cache, or something similar.

Comment 3

[Glenn Watson [:gw]]

I profiled this briefly - in this case it's actually text shadows being used for the effect. We'll want to cache text-shadow blurs, just as we do for box-shadows.

Comment 4

[Mark]

Could bug 1452489 be a (long winded) duplicate of this?

Comment 5

[Maire Reavy [:mreavy]]

We can't release this to the field, but we can let this ride to beta.

Comment 6

[Glenn Watson [:gw]]

The initial patch for picture caching on text shadows is https://github.com/servo/webrender/pull/3270. The commit mentions:

This brings the GPU time in the cloud ad [1] from 43 ms down to
8 ms for me. This is still higher than we want, due to the very high
number of cached text shadows that get composited. This should be
resolved as we support nested picture caching.

I think it's probably OK to verify and mark this as fixed once that lands, as it makes the performance very usable. It's just not as fast as we want / expect it to be in the future.

Comment 7

[Glenn Watson [:gw]]

This works really well now, with picture caching enabled by default.