Closed Bug 1436197 Opened 6 years ago Closed 6 years ago

Intermittent devtools/client/netmonitor/test/browser_net_timing-division.js | There should be at least one division on the seconds time scale. -

Categories

(DevTools :: Netmonitor, defect, P5)

Product:
DevTools
Component:
Netmonitor
Type:
defect

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Honza)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1436197 - Make more space for the Waterfall column;
59 bytes, text/x-review-board-request
ochameau
: review+
Details 
Filed by: rgurzau [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=160644931&repo=autoland

https://queue.taskcluster.net/v1/task/Cbd2b9pEQ4KFRB8_533jgw/runs/0/artifacts/public/logs/live_backing.log

[task 2018-02-06T20:23:48.702Z] 20:23:48     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_timing-division.js | There should be at least one division on the seconds time scale. - 
[task 2018-02-06T20:23:48.703Z] 20:23:48     INFO - Stack trace:
[task 2018-02-06T20:23:48.704Z] 20:23:48     INFO -     chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_timing-division.js:null:43
[task 2018-02-06T20:23:48.705Z] 20:23:48     INFO -     Tester_execTest@chrome://mochikit/content/browser-test.js:1056:9
[task 2018-02-06T20:23:48.706Z] 20:23:48     INFO -     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:956:9
[task 2018-02-06T20:23:48.706Z] 20:23:48     INFO -     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
This bug has failed 30 times in the last 7 days mainly on Windows 10 but there is one Linux fail, affecting opt and debug build type.
Failed test:debug-mochitest-devtools-chrome-e10 
Link to a recent log:https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=166353507&lineNumber=9132
Part of that log:00:48:42     INFO -  430 INFO TEST-PASS | devtools/client/netmonitor/test/browser_net_timing-division.js | There should be only two requests made. -
00:48:42     INFO -  Buffered messages finished
00:48:42    ERROR -  431 INFO TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_timing-division.js | There should be at least one division on the seconds time scale. -
00:48:42     INFO -  Stack trace:
00:48:42     INFO -      chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_timing-division.js:null:43
00:48:42     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:1058:9
00:48:42     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:958:9
00:48:42     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

:Honza could you please take a look at this bug?
Flags: needinfo?(odvarko)
Flags: needinfo?(odvarko)
Comment on attachment 8957128 [details]
Bug 1436197 - Make more space for the Waterfall column;

https://reviewboard.mozilla.org/r/226062/#review231996

Looks good, but does it really fix this intermittent?
You try is on linux, whereas comment 5 says it mostly occurs on windows.
Also you need to trigger many runs of the test job that includes the offending test.

So, to push on windows, you should do:
  try: -b do -p win64 -u mochitest-dt --artifact
Then find in which "dtX" browser_net_timing-division.js runs.
Once you found it, press "r" key like 10 times, in order to re-run it.
 (you have to be signed into treeherder to do that, there is a button in the very top right of treeherder UI to sign in with your LDAP)

::: devtools/client/netmonitor/test/browser_net_timing-division.js:13
(Diff revision 1)
> -
>  add_task(async function () {
> +  // Show only few columns, so there is enough space
> +  // for the waterfall.
> +  Services.prefs.setCharPref("devtools.netmonitor.visibleColumns",
> +    '["status", "contentSize", "waterfall"]');

You should use pushPref like this:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/test/browser_net_cached-status.js#12
In order to ensure reseting the pref back to its original value when this test ends.
Otherwise you will change the behavior of all tests running after this one.
Attachment #8957128 - Flags: review?(poirot.alex) → review+
(In reply to Alexandre Poirot [:ochameau] from comment #8)
> Comment on attachment 8957128 [details]
> Bug 1436197 - Make more space for the Waterfall column;
> 
> https://reviewboard.mozilla.org/r/226062/#review231996
> 
> Looks good, but does it really fix this intermittent?
Look at a screenshot taken for the failed test. It indicates that there is not much space for the timeline.
https://taskcluster-artifacts.net/Iv9gmEPwQXO5H9-izwQOdw/0/public/test_info/mozilla-test-fail-screenshot_i94uoa.png

> You try is on linux, whereas comment 5 says it mostly occurs on windows.
> Also you need to trigger many runs of the test job that includes the
> offending test.
> 
> So, to push on windows, you should do:
>   try: -b do -p win64 -u mochitest-dt --artifact
> Then find in which "dtX" browser_net_timing-division.js runs.
> Once you found it, press "r" key like 10 times, in order to re-run it.
>  (you have to be signed into treeherder to do that, there is a button in the
> very top right of treeherder UI to sign in with your LDAP)
Try looks good
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d754c8304c5094ffe5add3b8d4cc3fcb819debc3&selectedJob=166750260

> ::: devtools/client/netmonitor/test/browser_net_timing-division.js:13
> (Diff revision 1)
> > -
> >  add_task(async function () {
> > +  // Show only few columns, so there is enough space
> > +  // for the waterfall.
> > +  Services.prefs.setCharPref("devtools.netmonitor.visibleColumns",
> > +    '["status", "contentSize", "waterfall"]');
> 
> You should use pushPref like this:
> https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/test/
> browser_net_cached-status.js#12
> In order to ensure reseting the pref back to its original value when this
> test ends.
> Otherwise you will change the behavior of all tests running after this one.
Done 

Thanks!
Honza
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78f9dd3eb084
Make more space for the Waterfall column; r=ochameau
Assignee: nobody → odvarko
https://hg.mozilla.org/mozilla-central/rev/78f9dd3eb084
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: