Closed
Bug 1436218
Opened 6 years ago
Closed 6 years ago
Update Screenshots to version 29.0.0
Categories
(Firefox :: Screenshots, enhancement)
Firefox
Screenshots
Tracking
()
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: jhirsch, Assigned: jhirsch)
Details
Attachments
(2 files)
Update Screenshots to 29.0.0, latest version in github. Changelog and Try links to be added in comments.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•6 years ago
|
||
Complete changelog: https://github.com/6a68/screenshots/blob/version-29-0-0/CHANGELOG.md#version-2900 Add-on changes: * Suppress errors encountered when sending timing or events pings Analytics network errors should never be user-visible. [73c1340](https://github.com/mozilla-services/screenshots/commit/73c1340) * Remove special click handlers for onboarding legal and terms links Bug 1357589 has been fixed, so the links should now behave normally. Refs [#2699](https://github.com/mozilla-services/screenshots/issues/2699). [80a58e4](https://github.com/mozilla-services/screenshots/commit/80a58e4) * remove pageshot migration code. Fixes [#3844](https://github.com/mozilla-services/screenshots/issues/3844) [102724c](https://github.com/mozilla-services/screenshots/commit/102724c) * use data-l10n-title to localize title attributes. Fixes [#3840](https://github.com/mozilla-services/screenshots/issues/3840) [c962142](https://github.com/mozilla-services/screenshots/commit/c962142) * Do not throw error on unexpected attr in prod. ([#3959](https://github.com/mozilla-services/screenshots/issues/3959)) [2575e38](https://github.com/mozilla-services/screenshots/commit/2575e38) * Remove a button position fix that's no longer needed. ([#4008](https://github.com/mozilla-services/screenshots/issues/4008)) [b956bf7](https://github.com/mozill a-services/screenshots/commit/b956bf7) * Check capture type before it's potentially changed. ([#3968](https://github.com/mozilla-services/screenshots/issues/3968)) [b9ce266](https://github.com/mozilla-services/screenshots/commit/b9ce266) * Replace shot creating url w/ view url from addon. ([#3995](https://github.com/mozilla-services/screenshots/issues/3995)) ([#4009](https://github.com/mozilla-services/screenshots/issues/4009)) [43ad2df](https://github.com/mozilla-services/screenshots/commit/43ad2df) * Download or copy preview img when possible. ([#3968](https://github.com/mozilla-services/screenshots/issues/3968)) ([#4004](https://github.com/mozilla-services/screenshots/issues/4004)) [6aa2deb](https://github.com/mozilla-services/screenshots/commit/6aa2deb) * Prevent Enter from performing two actions. ([#3981](https://github.com/mozilla-services/screenshots/issues/3981)) [be59362](https://github.com/mozilla-services/screenshots/commit/be59362) * Refactor 'History enabled' checking code to clarify the expected boolean result [bc7b20a](https://github.com/mozilla-services/screenshots/commit/bc7b20a) * Refactor 'Telemetry enabled' checking code to clarify the expected boolean result [c8b1747](https://github.com/mozilla-services/screenshots/commit/c8b1747) * Update the download-only notice to mention ESR and upload-disabled prefs [90fbe9a](https://github.com/mozilla-services/screenshots/commit/90fbe9a) * disable uploads for ESR. Fixes [#3996](https://github.com/mozilla-services/screenshots/issues/3996) [f99e449](https://github.com/mozilla-services/screenshots/commit/f99e449) * Add 'Upload disabled' check to the selector code [a0c6626](https://github.com/mozilla-services/screenshots/commit/a0c6626) * Add upload-disabled pref and bootstrap message to send its value to webextension [022096d](https://github.com/mozilla-services/screenshots/commit/022096d) * Remove unused signal [5867cfd](https://github.com/mozilla-services/screenshots/commit/5867cfd) * Remove dimension limits when copying full page shots. ([#3855](https://github.com/mozilla-services/screenshots/issues/3855)) ([#3990](https://github.com/mozilla-services/screenshots/issues/3990)) [798d6dd](https://github.com/mozilla-services/screenshots/commit/798d6dd) * Clear cached highlighted el when hiding hover box. ([#3970](https://github.com/mozilla-services/screenshots/issues/3970)). [342e204](https://github.com/mozilla-services/screenshots/commit/342e204) * Negate body shift in scroll-proof fashion. ([#3907](https://github.com/mozilla-services/screenshots/issues/3907)) [8fd35ef](https://github.com/mozilla-services/screenshots/commit/8fd35ef) * Stop sending events when in incognito. ([#3900](https://github.com/mozilla-services/screenshots/issues/3900)) [de5e6a0](https://github.com/mozilla-services/screenshots/commit/de5e6a0) * Fix math on distance calc. ([#3922](https://github.com/mozilla-services/screenshots/issues/3922)) [6b7fafe](https://github.com/mozilla-services/screenshots/commit/6b7fafe) * Use an object url for the preview image. ([#3940](https://github.com/mozilla-services/screenshots/issues/3940)) [9e56cf2](https://github.com/mozilla-services/screenshots/commit/9e56cf2) * Fix selection frame when body's (left, top) is not (0, 0). ([#3907](https://github.com/mozilla-services/screenshots/issues/3907)) [f41db05](https://github.com/mozilla-services/screenshots/commit/f41db05) * Hide UI frame unless server error. ([#3901](https://github.com/mozilla-services/screenshots/issues/3901)) [7d9e51f](https://github.com/mozilla-services/screenshots/commit/7d9e51f)
Assignee | ||
Comment 4•6 years ago
|
||
Try push with Talos jobs: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e50de9a38ed5fca710a23d9ba218a51aa7abece
Assignee | ||
Comment 5•6 years ago
|
||
Talos looks good. Confirmed with :jmaher. Waiting on ianb for the r+
Flags: needinfo?(ianb)
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8948847 [details] Bug 1436218 - Export Screenshots 29.0.0 to Firefox (translations only); https://reviewboard.mozilla.org/r/218228/#review224330
Attachment #8948847 -
Flags: review+
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8948848 [details] Bug 1436218 - Export Screenshots 29.0.0 to Firefox (code excluding translations); https://reviewboard.mozilla.org/r/218230/#review224332 ::: browser/extensions/screenshots/moz.build:60 (Diff revision 1) > > FINAL_TARGET_FILES.features['screenshots@mozilla.org']["webextension"]["_locales"]["bn_BD"] += [ > 'webextension/_locales/bn_BD/messages.json' > ] > > +FINAL_TARGET_FILES.features['screenshots@mozilla.org']["webextension"]["_locales"]["br"] += [ This file should go in the locales, maybe we should add some documentation about that.
Attachment #8948848 -
Flags: review+
Updated•6 years ago
|
Flags: needinfo?(ianb)
Assignee | ||
Comment 8•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8948848 [details] Bug 1436218 - Export Screenshots 29.0.0 to Firefox (code excluding translations); https://reviewboard.mozilla.org/r/218230/#review224332 > This file should go in the locales, maybe we should add some documentation about that. Good idea. I'll add a one-liner to the export docs.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8948847 -
Flags: review?(francesco.lodolo)
Comment 11•6 years ago
|
||
Comment on attachment 8948847 [details] Bug 1436218 - Export Screenshots 29.0.0 to Firefox (translations only); Thanks, I can't spot anything wrong.
Attachment #8948847 -
Flags: review?(francesco.lodolo) → review+
Assignee | ||
Comment 12•6 years ago
|
||
QA testing didn't turn up any new major issues; merging.
Comment 13•6 years ago
|
||
Pushed by jhirsch@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e8749aa9714 Export Screenshots 29.0.0 to Firefox (translations only); r=ianbicking https://hg.mozilla.org/integration/autoland/rev/db28301bc63b Export Screenshots 29.0.0 to Firefox (code excluding translations); r=ianbicking
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5e8749aa9714 https://hg.mozilla.org/mozilla-central/rev/db28301bc63b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5e8749aa9714 https://hg.mozilla.org/mozilla-central/rev/db28301bc63b
Updated•6 years ago
|
Assignee: nobody → jhirsch
You need to log in
before you can comment on or make changes to this bug.
Description
•