1436248 - browser_shortcutkey_modifier_conflicts_with_content_accesskey_modifier.js is going to permafail when Gecko 60 merges to Beta on 2018-03-01

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Depending on a feature that's behind a NIGHTLY_BUILD pref?

https://treeherder.mozilla.org/logviewer.html#?job_id=160713484&repo=try

The patch below should suffice for reproducing the failure locally:
https://hg.mozilla.org/try/rev/18bae3eb5e94d4e17c97ebed1f23c4bbc352e923

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, you're right. "selectionchange" event in <input> and <textarea> is enabled only in Nightly build:
https://searchfox.org/mozilla-central/rev/84cea84b12145d752e50ddca6be5462c38510e35/modules/libpref/init/all.js#150-155

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4479daced0e95723cd2e8c4ae3603ff9a9a728e2

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1436248 - Don't use selectionchange event in browser-chrome test since it's not standardized yet whether it should be fired on <input> and <textarea> +6102

In current draft, selectionchange event should be fired when Selection is
changed in Document.  However, selection of <input> and <textarea> is different
from Selection in web standards (although our implementation uses Selection).

So, we should check it with SimpleText.executeSoon() for now since it might
be possible that selectionchange event in <input> and <textarea> would be
removed completely.

Review commit: https://reviewboard.mozilla.org/r/218300/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218300/

Comment 4

[Neil Deakin]

Comment on attachment 8948903 [details]
Bug 1436248 - Don't use selectionchange event in browser-chrome test since it's not standardized yet whether it should be fired on <input> and <textarea> +6102

https://reviewboard.mozilla.org/r/218300/#review224174

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3304400da8cb
Don't use selectionchange event in browser-chrome test since it's not standardized yet whether it should be fired on <input> and <textarea> r=enndeakin+6102+6102

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/3304400da8cb

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Thanks for the quick fix!

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8948903 [details]
Bug 1436248 - Don't use selectionchange event in browser-chrome test since it's not standardized yet whether it should be fired on <input> and <textarea> +6102

Approval Request Comment
[Feature/Bug causing the regression]:
Fixing new test's permanent orange of bug 1435530.

If we uplift patches for bug 1435530, we need to uplift this too. Otherwise, not necessary.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

OK, let's take this for beta 59 so we have the option to uplift.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8948903 [details]
Bug 1436248 - Don't use selectionchange event in browser-chrome test since it's not standardized yet whether it should be fired on <input> and <textarea> +6102

Changes to test so we can fix an e10s issue. Should land in time for beta 10.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b76b1af27cc1