Icons of attachments in composition have wrong aspect ratio (14x16px)

RESOLVED FIXED in Thunderbird 60.0

Status

defect
--
trivial
RESOLVED FIXED
Last year
Last year

People

(Reporter: bugzilla2007, Assigned: Paenglab)

Tracking

({polish})

Trunk
Thunderbird 60.0
Unspecified
Windows

Thunderbird Tracking Flags

(thunderbird59 fixed, thunderbird60 fixed)

Details

Attachments

(2 attachments)

Reporter

Description

Last year
STR

Have a close look at icons in attachment pane of composition,
or measure using a square 16x16px icon like the red icon in the attached screenshot.

Actual

They are too high, looking thin, not square.
Icons are scaled to 14x16 px (width x height), square aspect ratio lost.

Expected

We should preserve aspect ratio, i.e. 16x16px for icons.

Seen on Daily 60.0a1 (2018-02-04) (64-bit).

Richard?

Updated

Last year
Flags: needinfo?(richard.marti)
Assignee

Comment 1

Last year
There where some paddings in the .attachmentcell-icon which let the icons shrink.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #8949040 - Flags: review?(jorgk)

Comment 2

Last year
Comment on attachment 8949040 [details] [diff] [review]
Bug1436277.patch

Yes, that restores the proportions that I can see in TB 52. Which bug regressed that? Please request uplifts are needed.
Attachment #8949040 - Flags: review?(jorgk) → review+
Assignee

Comment 3

Last year
It was already in when I removed the XP/Vista part. Not checked before this.
Keywords: checkin-needed
Assignee

Comment 4

Last year
Comment on attachment 8949040 [details] [diff] [review]
Bug1436277.patch

Beta should be enough.
Attachment #8949040 - Flags: approval-comm-beta?

Comment 5

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/bdae925ebec3
Remove the padding of .attachmentcell-icon so icons are 16px high/wide. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

Last year
Target Milestone: --- → Thunderbird 60.0

Updated

Last year
Attachment #8949040 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.