Closed
Bug 1436285
Opened 7 years ago
Closed 7 years ago
Get a rid of nsIDOMNode version of GetNodeLocation, GetStartNodeAndOffset and GetEndNodeAndOffset
Categories
(Core :: DOM: Editor, enhancement, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
Details
Attachments
(2 files)
|
Bug 1436285 - Part 1. Don't use nsIDOMNode version of GetStartNodeAndOffset and GetEndNodeAndOffset.
59 bytes,
text/x-review-board-request
|
masayuki
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
masayuki
:
review+
|
Details |
No description provided.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8954644 [details]
Bug 1436285 - Part 1. Don't use nsIDOMNode version of GetStartNodeAndOffset and GetEndNodeAndOffset.
https://reviewboard.mozilla.org/r/223714/#review229760
Although, we should remove GetNodeAndOffset() for avoiding unnecessary computation of index.
Attachment #8954644 -
Flags: review?(masayuki) → review+
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8954645 [details]
Bug 1436285 - Part 2. Get a rid of nsIDOMNode version of GetNodeLocation, GetStartNodeAndOffset, GetEndNodeAndOffset and etc.
https://reviewboard.mozilla.org/r/223716/#review229762
Attachment #8954645 -
Flags: review?(masayuki) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/2e9e33c016a0
Part 1. Don't use nsIDOMNode version of GetStartNodeAndOffset and GetEndNodeAndOffset. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/1795687786a6
Part 2. Get a rid of nsIDOMNode version of GetNodeLocation, GetStartNodeAndOffset, GetEndNodeAndOffset and etc. r=masayuki
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2e9e33c016a0
https://hg.mozilla.org/mozilla-central/rev/1795687786a6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•