1436295 - Hits warning assertion The offset is out of bounds: '!mParent || mOffset.value() <= mParent->Length()' EditorDOMPoint.h, line 373 in HTMLEditRules::WillInsertBreak()

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> GECKO(80644) | [Child 14372, Main Thread] ###!!! ASSERTION: The offset is out of bounds: '!mParent || mOffset.value() <= mParent->Length()', file c:\mozilla\fx64-dbg\dist\include\mozilla/EditorDOMPoint.h, line 373
> GECKO(80644) | #01: mozilla::HTMLEditRules::WillInsertBreak (c:\mozilla\src\editor\libeditor\htmleditrules.cpp:1793)
> GECKO(80644) | #02: mozilla::HTMLEditRules::WillDoAction (c:\mozilla\src\editor\libeditor\htmleditrules.cpp:639)
> GECKO(80644) | #03: mozilla::TextEditor::InsertLineBreak (c:\mozilla\src\editor\libeditor\texteditor.cpp:746)
> GECKO(80644) | #04: mozilla::TextEditor::TypedText (c:\mozilla\src\editor\libeditor\texteditor.cpp:408)
> GECKO(80644) | #05: mozilla::HTMLEditor::TypedText (c:\mozilla\src\editor\libeditor\htmleditor.cpp:958)
> GECKO(80644) | #06: mozilla::HTMLEditor::HandleKeyPressEvent (c:\mozilla\src\editor\libeditor\htmleditor.cpp:681)
> GECKO(80644) | #07: mozilla::EditorEventListener::KeyPress (c:\mozilla\src\editor\libeditor\editoreventlistener.cpp:608)

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9752ac7e11af830eba633bd67d329c430c240cbb

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1436295 - HTMLEditRules::WillInsertBreak() should cancel resetting EditorDOMPoint when HTMLEditRules::ReturnInParagraph() splits DOM node around the point

This patch only fixes warning, not changing actual behavior of editor.

HTMLEditRules::ReturnInParagraph() splits paragraph *around* given point.
Therefore, from point of view of caller, offset of setting point may be
invalid after HTMLEditRules::ReturnInParagraph() handled the edit action.
In this case, invalidating stored child of the point may cause warning
since offset may be larger than length of its container.

So, if HTMLEditRules::ReturnInParagraph() handles the edit action,
the caller, HTMLEditRules::WillInsertBreak(), should cancel invalidating
the stored child for avoiding unnecessary warning.

Review commit: https://reviewboard.mozilla.org/r/218660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218660/

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8949284 [details]
Bug 1436295 - HTMLEditRules::WillInsertBreak() should cancel resetting EditorDOMPoint when HTMLEditRules::ReturnInParagraph() splits DOM node around the point

https://reviewboard.mozilla.org/r/218660/#review224702

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e05678d156d9
HTMLEditRules::WillInsertBreak() should cancel resetting EditorDOMPoint when HTMLEditRules::ReturnInParagraph() splits DOM node around the point r=m_kato

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/e05678d156d9