1436305 - [in-tree scheduling] shipping releases emails are lies

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement, P1)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

Whenever we trigger shipping phase, the emails are triggered as well saying the "release has been shipped". This is a lie since we only schedule them in Balrog, pending RelMan & RelEng approval. 

We need to amend the notifications in such a way that either:
a) they mention when the change is scheduled (most likely ETA from Ship-it passed down to action task and then to in-tree scheduling)
b) at least say the release has `been scheduled to be shipped in Balrog pending signoffs` instead of the current message.

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Fix lies by amending the notifications message.

How about we start with this approach for now? In the cleanup section we can improve this by passing the ETA from Ship-it via action task down to tasks, to specify the timing as well, as we have in releasetasks old logic.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8949034 [details] [diff] [review]
Fix lies by amending the notifications message.

Review of attachment 8949034 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/ci/release-notify-ship/kind.yml
@@ +66,5 @@
>        index:
>           product: firefox
> +      notifications:
> +         completed:
> +            subject: "{task[shipping-product]} {release_config[version]} build{release_config[build_number]}/{config[params][project]} has shipped with pending updates in Balrog for signoff!"

"... has shipped with pending updates" is kindof a contradiction. How about "... updates are ready for signoff in Balrog" ?

Comment 3

[[e-mail] (:bhearsum)]

This might be causing https://bugzilla.mozilla.org/show_bug.cgi?id=1436501

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/faaa816fdb9d
fix notifications lies. r=bhearsum a=release

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

https://hg.mozilla.org/releases/mozilla-beta/rev/fc55ea1db218ace64f3e2579e3bb145afa09685f

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/faaa816fdb9d