Port bug 1432992 to TB: Remove definitions of Ci, Cr, Cc, and Cu

RESOLVED FIXED in Thunderbird 60.0

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 60.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 3 obsolete attachments)

Assignee

Description

Last year
To port it I used the script from bug 1432992: attachment 8948756 [details]
Assignee

Comment 1

Last year
Chat part
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8948947 - Flags: review?(florian)
Assignee

Comment 2

Last year
Posted patch CiCuCc-mail.patch (obsolete) — Splinter Review
Mail part with the only LDAP file
Attachment #8948948 - Flags: review?(jorgk)
Assignee

Comment 3

Last year
Posted patch CiCuCc-mailnews.patch (obsolete) — Splinter Review
Mailnews part
Attachment #8948949 - Flags: review?(jorgk)
Assignee

Comment 5

Last year
Comment on attachment 8948949 [details] [diff] [review]
CiCuCc-mailnews.patch

The comment should be:
Bug 1436310 - Port bug 1432992 to mailnews: Remove definitions of Ci, Cr, Cc, and Cu. r=jorgk

Jörg, when no patch update is needed, can you fix this on check-in?
Comment on attachment 8948947 [details] [diff] [review]
CiCuCc-chat.patch

Review of attachment 8948947 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8948947 - Flags: review?(florian) → review+

Comment 7

Last year
Comment on attachment 8948948 [details] [diff] [review]
CiCuCc-mail.patch

Looks like your try has got a heap of failures, so this cannot be an r+ yet :-(
Attachment #8948948 - Flags: review?(jorgk)

Updated

Last year
Attachment #8948949 - Flags: review?(jorgk)

Comment 8

Last year
Comment on attachment 8948948 [details] [diff] [review]
CiCuCc-mail.patch

Review of attachment 8948948 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/accountcreation/content/util.js
@@ -3,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  /**
>   * Some common, generic functions
> - */

You killed the closing comment :-(((
That's kind of fatal.

Comment 9

Last year
Please do another try. macosx64 opt will be sufficient.
Assignee

Comment 10

Last year
Fixed the too much removed comment closing.
Attachment #8948948 - Attachment is obsolete: true
Attachment #8949046 - Flags: review?(jorgk)
Comment on attachment 8949046 [details] [diff] [review]
CiCuCc-mail.patch

Thanks.
Attachment #8949046 - Flags: review?(jorgk) → review+
Comment on attachment 8949052 [details] [diff] [review]
CiCuCc-mailnews.patch

Thanks, I actually read through the patches, that's how I noticed the comment problem.
Attachment #8949052 - Flags: review?(jorgk) → review+
Assignee

Updated

Last year
Keywords: checkin-needed

Comment 14

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f40eacb79d82
Port bug 1432992 to chat: Remove definitions of Ci, Cr, Cc, and Cu. r=florian
https://hg.mozilla.org/comm-central/rev/c32109102bb9
Port bug 1432992 to mail: Remove definitions of Ci, Cr, Cc, and Cu. r=jorgk
https://hg.mozilla.org/comm-central/rev/e1013e31ffae
Port bug 1432992 to mailnews: Remove definitions of Ci, Cr, Cc, and Cu. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

Last year
Target Milestone: --- → Thunderbird 60.0
Any ambition to tackle the equivalent of bug 1433175 for C-C? We have tons of them, especially in Calendar.

NI Philipp just to make him aware.
Flags: needinfo?(philipp)
Assignee

Comment 16

Last year
Posted patch CiCuCc-calendar.patch (obsolete) — Splinter Review
calendar doesn't have a lot. It has a lot of own variables.
This here are all the script found.
Flags: needinfo?(philipp)
Attachment #8949139 - Flags: review?(philipp)
(In reply to Jorg K (GMT+1) from comment #15)
> Any ambition to tackle the equivalent of bug 1433175 for C-C? We have tons
> of them, especially in Calendar.
You didn't answer this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Comment 18

Last year
(In reply to Jorg K (GMT+1) from comment #17)
> (In reply to Jorg K (GMT+1) from comment #15)
> > Any ambition to tackle the equivalent of bug 1433175 for C-C? We have tons
> > of them, especially in Calendar.
> You didn't answer this.

Ah sorry. Saw Ci Cu in the bug title and thought it's for the patch I added.

Re n-i Philipp.
Flags: needinfo?(philipp)
Comment on attachment 8949139 [details] [diff] [review]
CiCuCc-calendar.patch

Review of attachment 8949139 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with this change. I was never really a fan of Cc/Ci, but I guess the trend is to use it.

::: calendar/providers/gdata/modules/OAuth2.jsm
@@ -6,5 @@
>   * Provides OAuth 2.0 authentication
>   */
>  var EXPORTED_SYMBOLS = ["OAuth2"];
>  
> -var {classes: Cc, interfaces: Ci, results: Cr, utils: Cu} = Components;

I'm removing this anyway in bug 1436199. Can you exclude this change to avoid bitrot?
Attachment #8949139 - Flags: review?(philipp) → review+
Flags: needinfo?(philipp)
Assignee

Comment 20

Last year
Removed the OAuth2 part.
Attachment #8949139 - Attachment is obsolete: true
Attachment #8949186 - Flags: review+
Assignee

Updated

Last year
Keywords: checkin-needed

Comment 21

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/3d13a7832ad7
Port bug 1432992 to calendar: Remove definitions of Ci, Cr, Cc, and Cu. r=philipp
Status: REOPENED → RESOLVED
Closed: Last yearLast year
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.