1436352 - Camera with microphone might have light on when disabled in application

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[ovidiu boca[:Ovidiu]]

Affected versions]:

Tested on Nightly 60.0a1(2018-02-07)

[Affected platforms]:

Tested on Windows 7 and Windows 10

[Steps to reproduce]:

Prerequisites:
 1. Make sure you have 2 cameras on your system.
 
 STR:

1. Open Firefox and go to Facebook and start a video call by selecting 1 of the cameras.

[Expected result]:

The camera starts to capture and the light is on. 

[Actual result]:

The light from both cameras is on. 

NOTE: This issue is reproducible only on Windows.

Comment 1

[Andreas Pehrson [:pehrsons]]

Would be good to understand whether this is fallout from bug 1299515 or something older. If it's truly platform specific I assume it's something to blame in the windows camera integration, which is upstream code.

Comment 2

[ovidiu boca[:Ovidiu]]

I tested this issue with a Nightly 59.0a1 build from 2018-01-11 on Windows 7 x64, I attached 2 USB cameras and try to start a video call on appear.in and jit.si and both cameras light turned on, so I think this is not a recent regression. Please let me know how can I help you further with this issue.

Comment 3

[Andreas Pehrson [:pehrsons]]

A regression window would always help. Could you run it through mozregression?
That of course assumes we have a version where it works as expected first.

Comment 4

[ovidiu boca[:Ovidiu]]

I think I found out what is the problem here. My first impression is that having 2 cameras when you choose your microphone and camera to share if you chose separately, the mic from one camera and the video capture from another one, both lights are turned on. I will investigate further but I I think this is the issue here.

Comment 5

[ovidiu boca[:Ovidiu]]

What do you think Andreas should we close this as invalid? Do you see any reason to keep this bug open?
Thanks

Comment 6

[Andreas Pehrson [:pehrsons]]

Well, the mic doesn't normally keep the camera light on. Can you confirm whether it turns on the light in an audio-only capture on https://mozilla.github.io/webrtc-landing/gum_test.html ?

Comment 7

[ovidiu boca[:Ovidiu]]

Tested on Mac and Windows and when I start to capture only audio the camera light is turned on, so the camera light is not turned on only if you start a video capture, this is expected?

Comment 8

[ovidiu boca[:Ovidiu]]

Updates: 

In the tests from comment 7, I used Microsoft LifeCam HD-3000 - camera light is on

I tested again with Webcam Logitech HD Pro C920 and the light is off. 

It seems that this is also related to what camera is used.

Comment 9

[Andreas Pehrson [:pehrsons]]

Right, so it seems the Microsoft LifeCam HD-3000 turns on the light also for audio capture. We're considering enabling the feature to turn off the capture while disabled also for audio.

Comment 10

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1436352 - Enable turning microphone off on track-disable by default.

Review commit: https://reviewboard.mozilla.org/r/221366/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221366/

Comment 11

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8952142 [details]
Bug 1436352 - Enable turning microphone off on track-disable by default.

https://reviewboard.mozilla.org/r/221366/#review227494

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5fa46ea1d22
Enable turning microphone off on track-disable by default. r=jib

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f5fa46ea1d22

Comment 14

[ovidiu boca[:Ovidiu]]

I verified this on Windows 10 x64 Mac OS X 10.12 and Ubuntu 16.04 with Nightly (2018-02-21) using Microsoft LifeCam HD-3000.The site that I used is: https://mozilla.github.io/webrtc-landing/gum_test.html

 Mac and Windows results:

The camera light is turned on when I click on Audio -> Allow 
If I click on "Stop" the camera light is turned off almost instantly (from what I understand this is the new expected behavior)

Ubuntu result:

The camera light is turned on when I click on Audio -> Allow 
If I click on "Stop" the camera light is turned off but only after I wait a few seconds (This seems to be the old intended behavior).

Comment 15

[Andreas Pehrson [:pehrsons]]

(In reply to ovidiu boca[:Ovidiu] from comment #14)
> I verified this on Windows 10 x64 Mac OS X 10.12 and Ubuntu 16.04 with
> Nightly (2018-02-21) using Microsoft LifeCam HD-3000.The site that I used
> is: https://mozilla.github.io/webrtc-landing/gum_test.html
> 
>  Mac and Windows results:
> 
> The camera light is turned on when I click on Audio -> Allow 
> If I click on "Stop" the camera light is turned off almost instantly (from
> what I understand this is the new expected behavior)

No. Stop will stop the track. This bug is about turning the light off on *disable* (in code this means `track.enabled = false;`).

You will find that without this patch, the Stop button functions as expected as well.

You can use a website that sets track.enabled to verify this. Appear.in does this for instance. Or use https://jsfiddle.net/pehrsons/41ypdtv0/ that I just wrote.

Comment 16

[ovidiu boca[:Ovidiu]]

Ok, I used your test case and on Mac and Windows with Microsoft LifeCam HD-3000, the camera light is turned off after ~3 sec. since the "Disable" button is clicked. 
On Ubuntu only after ~10 sec. the camera light is turned off.
 
The time for turning off the camera light wasn't supposed to be reduced?

Comment 17

[Andreas Pehrson [:pehrsons]]

Reducing the time is bug 1436074.

On Ubuntu there seems to be a delay from when we stop the pulseaudio stream until when pulseaudio closes the device. This is fine since it not something we can improve really.

Comment 18

[ovidiu boca[:Ovidiu]]

Thanks for clearing this out.
I will mark this as verified fixed based on the fact that the camera light is turned off when you disable the mic, and the Ubuntu delay will be handled in bug 1436074.

Comment 19

[Andreas Pehrson [:pehrsons]]

(In reply to ovidiu boca[:Ovidiu] from comment #18)
> the Ubuntu delay will be handled in bug 1436074.

No. The extra delay in pulseaudio is external and not something we can fix. Bug 1436074 is for making the delay zero unless you enabled the device less than three seconds ago.