Closed Bug 1436361 Opened 6 years ago Closed 6 years ago

Extract the async tab switcher from tabbrowser.js into its own JSM

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

Product:
Firefox
Component:
Tabbed Browser
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: mconley, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1436361 - Extract the async tab switcher from tabbrowser.js into its own JSM.
59 bytes, text/x-review-board-request
mconley
: review+
Details
hg diff -w
235.99 KB, patch
Details | Diff | Splinter Review 
The async tab switcher is a huge chunk of code embedded in an even larger chunk of code (tabbrowser.xml). Gijs suggested it might make sense to extract it into its own separate JSM. I'm inclined to agree.
Priority: -- → P3
Blocks: 1392352
If it helps, I have a tool to convert XBL code into a JS class at https://bgrins.github.io/xbl-analysis/converter/. There's also a migrated version of the tabbrowser binding based on the current m-c tip in the patch in Bug 1392352. Although it looks like this object may be pretty much contained in the _getSwitcher method and not use a lot of XBL specifics.
No longer blocks: 1392352
Depends on: 1392352
Assignee: nobody → dao+bmo
Summary: Extract the async tab switcher from tabbrowser.xml into its own JSM → Extract the async tab switcher from tabbrowser.js into its own JSM
Attached patch hg diff -w — — Splinter Review 
This should be easier to review.
Comment on attachment 8955455 [details] [diff] [review]
hg diff -w

Review of attachment 8955455 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I think extracting this out is the right move. Thanks!
Attachment #8955455 - Flags: review+
cc'ing dthayer, who's been working on the async tab switcher, so that he's aware of what's going on here.
Comment on attachment 8955455 [details] [diff] [review]
hg diff -w

Bah - r+'d the wrong thing.
Attachment #8955455 - Flags: review+
Comment on attachment 8955454 [details]
Bug 1436361 - Extract the async tab switcher from tabbrowser.js into its own JSM.

https://reviewboard.mozilla.org/r/224616/#review231008
Attachment #8955454 - Flags: review?(mconley) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d85720211dd
Extract the async tab switcher from tabbrowser.js into its own JSM. r=mconley
https://hg.mozilla.org/mozilla-central/rev/3d85720211dd
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: