Closed Bug 1436375 Opened 2 years ago Closed 2 years ago

DrawTargetRecording doesn't create ScaledFonts for non-indexed case

Categories

(Core :: Graphics, defect)

58 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox-esr52 --- unaffected
firefox58 --- wontfix
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: lsalzman, Assigned: lsalzman)

References

Details

(Keywords: regression, Whiteboard: [gfx-noted])

Attachments

(1 file)

It looks like when DrawTargetRecording was refactored to support indexed fonts, the RecordedScaledFontCreation event went missing... This should probably be put back.
Attachment #8949021 - Flags: review?(jmuizelaar)
Attachment #8949021 - Flags: review?(jmuizelaar) → review+
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d16a102c8887
add RecordedScaledFontCreation event in DrawTargetRecording::FillGlyphs. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/d16a102c8887
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Is this something we should consider uplifting to Beta or can it ride the trains?
Flags: needinfo?(lsalzman)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> Is this something we should consider uplifting to Beta or can it ride the
> trains?

It seems innocuous so far. I only spot it via eyeballing, and we haven't observed any symptoms from this yet. So for now, unless there's a bug that pops up from it, maybe just let it ride the trains.
Flags: needinfo?(lsalzman)
You need to log in before you can comment on or make changes to this bug.