Closed Bug 1436377 Opened 2 years ago Closed 2 years ago

Policy engine - Implement URLorEmpty parameter type

Categories

(Firefox :: Enterprise Policies, enhancement)

60 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

Attachments

(1 file)

There are some pairs of policy requests that go like this:

 - Show a custom first run page
 - Don't show the first run page

We could implement them under just one policy, "FirstRunPage" for example, if we have a param type that accepts either a URL or an empty string.

The existing URL type requires it to be a valid URL and I don't want to make it also accept empty values, so it's better to introduce a new type.
Comment on attachment 8949032 [details]
Bug 1436377 - Policy engine - Implement URLorEmpty parameter type.

https://reviewboard.mozilla.org/r/218430/#review224362
Attachment #8949032 - Flags: review?(dtownsend) → review+
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbcf611ca8b9
Policy engine - Implement URLorEmpty parameter type. r=Mossop
https://hg.mozilla.org/mozilla-central/rev/bbcf611ca8b9
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.