Closed Bug 1436380 Opened 2 years ago Closed 2 years ago

Web Console Tabs async fix ready for React 16

Categories

(DevTools :: Framework, enhancement, P2)

enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: miker, Assigned: miker)

Details

Attachments

(1 file)

In the Web Console when AJAX calls are logged and the line expanded there are a number of tabs. Under React 16 these tabs fail to switch properly due to an async error caused by setting the state without a callback.

This can safely be landed before React 16 so I have broken it out into a new bug.
Comment on attachment 8949043 [details]
Bug 1436380 - Fix async issues in TabBar.js r+nchevobbe

https://reviewboard.mozilla.org/r/218450/#review224234

nchevobbe r+ssed this as part of bug 1416824
Attachment #8949043 - Flags: review+
Attachment #8949043 - Flags: review?(nchevobbe)
Comment on attachment 8949043 [details]
Bug 1436380 - Fix async issues in TabBar.js r+nchevobbe

https://reviewboard.mozilla.org/r/218450/#review224236
Attachment #8949043 - Flags: review?(nchevobbe) → review+
Has Regression Range: --- → irrelevant
Has STR: --- → yes
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fc3ea5161d6
Fix async issues in TabBar.js r+nchevobbe r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/9fc3ea5161d6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.