Closed Bug 1436415 Opened 5 years ago Closed 5 years ago

Investigate and restore NS_FRAME_SIMPLE_DISPLAYLIST fast path if needed

Categories

(Core :: Web Painting, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: mikokm, Assigned: mikokm)

References

Details

Attachments

(2 files)

Follow-up to bug 1434243.

Since the display list building fast path currently requires nsDisplayLayerEventRegions [1], it won't work after the changes in bug 1434243.

This bug tracks measuring the benefit of the optimization, and either removing the code or restoring it.

[1]: https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/layout/generic/nsFrame.cpp#3504
Assignee: nobody → mikokm
Status: NEW → ASSIGNED
Comment on attachment 8950449 [details]
Bug 1436415 - Part 1: Reuse some local variables in nsIFrame::BuildDisplayListForChild()

https://reviewboard.mozilla.org/r/219720/#review225452
Attachment #8950449 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8950450 [details]
Bug 1436415 - Part 2: Enable nsIFrame::BuildDisplayListForChild() fast-path when using simple event region items

https://reviewboard.mozilla.org/r/219722/#review225454
Attachment #8950450 - Flags: review?(matt.woodrow) → review+
Priority: -- → P2
Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ac5114349a31
Part 1: Reuse some local variables in nsIFrame::BuildDisplayListForChild() r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/2c081ff593c6
Part 2: Enable nsIFrame::BuildDisplayListForChild() fast-path when using simple event region items r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/ac5114349a31
https://hg.mozilla.org/mozilla-central/rev/2c081ff593c6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.