1436437 - Change one instance of LongBrandName to ShortBrandName on Nightly You've been upgraded page

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[mheubusch]

For this page: https://www.mozilla.org/en-US/firefox/59.0a1/whatsnew/?oldversion=57.0.1

Please change this line of text: <div class="body">
            <p>
              This is a good time to thank you for helping us make Firefox better and to give you some pointers to documentation, communication channels and news sites related to Firefox Nightly that may be of interest to you.
            </p>

To this (changing Firefox Nightly to Nightly): <div class="body">
            <p>
              This is a good time to thank you for helping us make Firefox better and to give you some pointers to documentation, communication channels and news sites related to Nightly that may be of interest to you.
            </p>

This is to follow our convention of using the long name on first reference and short name on all subsequent references.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Kohei, could you please take care of that? Thanks

Comment 2

[Pascal Chevrel:pascalc]

Francesco, can we go ahead and change the wording without introducing an l10n conditional in the template? Next merge date is March 12, given that this is a branding change and we don't localize our brand name, I am thinking that you could script it across our locales and let localizers do QA after the change.

Comment 3

[Francesco Lodolo [:flod]]

Redirecting to Peiying, since mozilla.org is her project.

I've checked, and there are a few locales that might not be safe to touch via script (cs, maybe ko, zh-CN)
https://transvision.mozfr.org/string/?entity=mozilla_org/firefox/nightly_whatsnew.lang:7a2e0e471af4e1cb37999cdd62fa3373&repo=mozilla_org

Comment 4

[Peiying Mo [:CocoMo]]

> I've checked, and there are a few locales that might not be safe to touch
> via script (cs, maybe ko, zh-CN)
> https://transvision.mozfr.org/string/?entity=mozilla_org/firefox/
> nightly_whatsnew.lang:7a2e0e471af4e1cb37999cdd62fa3373&repo=mozilla_org

zh-CN doesn't mention Nightly, so it is good as is.

Comment 5

[Kohei Yoshino [:kohei]]

Okay, then I'm sending a PR without a l10n switch.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Kohei Yoshino [:kohei] from comment #5)
> Okay, then I'm sending a PR without a l10n switch.

Just to confirm: per discussion with Pei on IRC, let's go ahead without l10n tag. I'll change the l10n files once that's merged.

Comment 7

[Pascal Chevrel:pascalc]

(In reply to Peiying Mo [:CocoMo] from comment #4)
> > I've checked, and there are a few locales that might not be safe to touch
> > via script (cs, maybe ko, zh-CN)
> > https://transvision.mozfr.org/string/?entity=mozilla_org/firefox/
> > nightly_whatsnew.lang:7a2e0e471af4e1cb37999cdd62fa3373&repo=mozilla_org
> 
> zh-CN doesn't mention Nightly, so it is good as is.

Can you please file a follow up bug to get this fixed? Thanks

Comment 8

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/bedrock/pull/5442

Comment 9

[Peiying Mo [:CocoMo]]

(In reply to Pascal Chevrel:pascalc from comment #7)
> (In reply to Peiying Mo [:CocoMo] from comment #4)
> > > I've checked, and there are a few locales that might not be safe to touch
> > > via script (cs, maybe ko, zh-CN)
> > > https://transvision.mozfr.org/string/?entity=mozilla_org/firefox/
> > > nightly_whatsnew.lang:7a2e0e471af4e1cb37999cdd62fa3373&repo=mozilla_org
> > 
> > zh-CN doesn't mention Nightly, so it is good as is.
> 
> Can you please file a follow up bug to get this fixed? Thanks

I fixed zh-CN in Pontoon, it now says Firefox Nightly (second instance). Should be ready in the next sync.

Comment 10

[Francesco Lodolo [:flod]]

At this point cs, pl, sk will require manual fixes from localizers, since they decline Firefox.

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/96c568f9cb493442e2e2962e99317094941fb309
Fix Bug 1436437 - Change one instance of LongBrandName to ShortBrandName on Nightly You've been upgraded page