1436475 - Update vendored 7-zip self-extractor code to 18.01

Status: RESOLVED FIXED

(Firefox :: Installer, enhancement, P1)

Description

[Molly Howell (she/her) (no longer active)]

The code that we build our 7-zip SFX module from looks to be based on version 4.42, released in 2006. If nothing else, we can probably expect to get improved performance out of updating to the current 18.01 release.

In the process, we should also collect our changes to this code into a patch file, to make future updates easier; this one is going to be kind of a pain.

Note that this is *not* a response to the security issues recently reported in 7-zip (CVE-2017-17969 and CVE-2018-5996). We do not use the formats implicated in those issues. Reading that report did get me thinking about this, though.

Comment 1

[Molly Howell (she/her) (no longer active)]

The performance difference is greater than I expected; on my machine (which has a very fast CPU and an SSD), the time to extract the full installer went from 6.3 seconds to 4.3 seconds, averaged over 5 runs. So I think I'll go ahead and get on this.

Comment 2

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1436475 Part 1 - Remove the old 7-zip code.

Review commit: https://reviewboard.mozilla.org/r/220012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220012/

Comment 3

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1436475 Part 2 - Add the 7-zip 18.01 code.

Review commit: https://reviewboard.mozilla.org/r/220014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220014/

Comment 4

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1436475 Part 3 - Port our customizations forward to the new 7-zip code.

Review commit: https://reviewboard.mozilla.org/r/220016/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220016/

Comment 5

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1436475 Part 4 - Add the 7-zip SFX binary compiled from the new code, and related resources.

Review commit: https://reviewboard.mozilla.org/r/220018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220018/

Comment 6

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1436475 Part 5 - Add a readme and a patch file with our changes to the 7-zip directory.

Review commit: https://reviewboard.mozilla.org/r/220020/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220020/

Comment 7

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Comment on attachment 8950765 [details]
Bug 1436475 Part 1 - Remove the old 7-zip code.

https://reviewboard.mozilla.org/r/220012/#review226162

Comment 8

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Comment on attachment 8950766 [details]
Bug 1436475 Part 2 - Add the 7-zip 18.01 code.

https://reviewboard.mozilla.org/r/220014/#review226164

Comment 9

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Comment on attachment 8950767 [details]
Bug 1436475 Part 3 - Port our customizations forward to the new 7-zip code.

https://reviewboard.mozilla.org/r/220016/#review226166

Comment 10

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Comment on attachment 8950768 [details]
Bug 1436475 Part 4 - Add the 7-zip SFX binary compiled from the new code, and related resources.

https://reviewboard.mozilla.org/r/220018/#review226170

Comment 11

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Comment on attachment 8950769 [details]
Bug 1436475 Part 5 - Add a readme and a patch file with our changes to the 7-zip directory.

https://reviewboard.mozilla.org/r/220020/#review226174

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ee15b723c4a
Part 1 - Remove the old 7-zip code. r=agashlin
https://hg.mozilla.org/integration/autoland/rev/1f6f1636a500
Part 2 - Add the 7-zip 18.01 code. r=agashlin
https://hg.mozilla.org/integration/autoland/rev/354ea5121c9c
Part 3 - Port our customizations forward to the new 7-zip code. r=agashlin
https://hg.mozilla.org/integration/autoland/rev/2a1c370690be
Part 4 - Add the 7-zip SFX binary compiled from the new code, and related resources. r=agashlin
https://hg.mozilla.org/integration/autoland/rev/66de6bae080a
Part 5 - Add a readme and a patch file with our changes to the 7-zip directory. r=agashlin

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0ee15b723c4a
https://hg.mozilla.org/mozilla-central/rev/1f6f1636a500
https://hg.mozilla.org/mozilla-central/rev/354ea5121c9c
https://hg.mozilla.org/mozilla-central/rev/2a1c370690be
https://hg.mozilla.org/mozilla-central/rev/66de6bae080a