Closed Bug 1436499 Opened 4 years ago Closed 4 years ago

Spin up a dev treescriptworker

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(2 files)

No description provided.
Attached file Github PR
Attachment #8949140 - Flags: review?(aki)
Comment on attachment 8949140 [details] [review]
Github PR

per rail on PR
Attachment #8949140 - Flags: review?(aki) → review+
Depends on: 1436781
Comment on attachment 8949802 [details]
Bug 1436499 - Spin up a dev treescriptworker.

https://reviewboard.mozilla.org/r/219108/#review224904

I still strongly recommend using a puppet env for this, so you can quickly iterate on tree scriptworker without blocking on reviews.

::: modules/tree_scriptworker/manifests/settings.pp:10
(Diff revision 1)
> +class tree_scriptworker::settings {
> +    $root                     = '/builds/scriptworker'
> +    $task_script              = "${root}/bin/treescript"
> +    $task_script_config       = "${root}/script_config.json"
> +    $task_max_timeout         = 1800
> +    $upstream_repo            = 'https://hg.mozilla.org/mozilla-unified'

At some point we may want to support multiple repos, especially if we add git support to treescript. Not something we have to add in now, but something to keep in mind.

::: modules/tree_scriptworker/manifests/settings.pp:28
(Diff revision 1)
> +        },
> +        'prod' => {
> +            taskcluster_client_id => 'project/releng/scriptworker/treescriptworker',
> +            # No prod secret yet, this line would break puppet if not commented out
> +            # taskcluster_access_token => secret('treescriptworker_prod_taskcluster_access_token'),
> +            worker_type => 'balrogworker-v1',

this is wrong.
Attachment #8949802 - Flags: review?(aki) → review+
Comment on attachment 8949802 [details]
Bug 1436499 - Spin up a dev treescriptworker.

https://reviewboard.mozilla.org/r/219108/#review224904

> At some point we may want to support multiple repos, especially if we add git support to treescript. Not something we have to add in now, but something to keep in mind.

I agree it's a good, nice-to-think-about.

> this is wrong.

good catch, thanks
Blocks: 1398787
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.