1436499 - Spin up a dev treescriptworker

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Comment 1

[Justin Wood (:Callek)]

Attachment: Github PR

Comment 2

[Justin Wood (:Callek)]

I landed some puppet boilerplate with https://hg.mozilla.org/build/puppet/rev/c06d0858d33482037f786807234715d6a868f96d

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8949140 [details] [review]
Github PR

per rail on PR

Comment 4

[Justin Wood (:Callek)]

Attachment: Bug 1436499 - Spin up a dev treescriptworker.

Review commit: https://reviewboard.mozilla.org/r/219108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219108/

Comment 5

[Aki Sasaki [:aki] (he/him) (UTC-6)]

Comment on attachment 8949802 [details]
Bug 1436499 - Spin up a dev treescriptworker.

https://reviewboard.mozilla.org/r/219108/#review224904

I still strongly recommend using a puppet env for this, so you can quickly iterate on tree scriptworker without blocking on reviews.

::: modules/tree_scriptworker/manifests/settings.pp:10
(Diff revision 1)
> +class tree_scriptworker::settings {
> +    $root                     = '/builds/scriptworker'
> +    $task_script              = "${root}/bin/treescript"
> +    $task_script_config       = "${root}/script_config.json"
> +    $task_max_timeout         = 1800
> +    $upstream_repo            = 'https://hg.mozilla.org/mozilla-unified'

At some point we may want to support multiple repos, especially if we add git support to treescript. Not something we have to add in now, but something to keep in mind.

::: modules/tree_scriptworker/manifests/settings.pp:28
(Diff revision 1)
> +        },
> +        'prod' => {
> +            taskcluster_client_id => 'project/releng/scriptworker/treescriptworker',
> +            # No prod secret yet, this line would break puppet if not commented out
> +            # taskcluster_access_token => secret('treescriptworker_prod_taskcluster_access_token'),
> +            worker_type => 'balrogworker-v1',

this is wrong.

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 8949802 [details]
Bug 1436499 - Spin up a dev treescriptworker.

https://reviewboard.mozilla.org/r/219108/#review224904

> At some point we may want to support multiple repos, especially if we add git support to treescript. Not something we have to add in now, but something to keep in mind.

I agree it's a good, nice-to-think-about.

> this is wrong.

good catch, thanks