Closed Bug 1436568 Opened 3 years ago Closed 3 years ago

Make "clear your recent history" a button instead of a link

Categories

(Firefox :: Preferences, defect, P1)

60 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 60
Tracking Status
firefox60 --- verified

People

(Reporter: johannh, Assigned: johannh)

References

(Blocks 1 open bug)

Details

(Whiteboard: [storage-v2])

Attachments

(1 file)

Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Comment on attachment 8952310 [details]
Bug 1436568 - Make "clear your recent history" a button instead of a link.

https://reviewboard.mozilla.org/r/221562/#review228546

Looks mostly good to me, thanks! Just one real comment:

Before this patch, when "Never remember history" is selected, we are forcing the time span value in the dialog to "Everything". After this patch, we aren't doing that, and I think it might be confusing for a user who has selected "Never remember" to see stuff like "Last hour"/"2 hours"/"Past day"/whatever. Let's preserve behavior - shouldn't be too complicated to implement.

::: browser/components/preferences/in-content/privacy.xul:99
(Diff revision 1)
>          </menupopup>
>        </menulist>
>      </hbox>
>      <label>&historyHeader.post.label;</label>
>    </hbox>
> -  <deck id="historyPane">
> +  <hbox>

I see that the spec suggests we place the button horizontally next to the pane, but please make sure this doesn't look too crowded when "Use custom settings for history" is selected.

::: browser/components/preferences/in-content/privacy.xul:161
(Diff revision 1)
>  <span class="indent">>></span>      </vbox>
>  <span class="indent">>></span>    </vbox>
>  <span class="indent">>></span>  </deck>
> +    <vbox align="end">
> +      <button id="clearHistoryButton"
> +          class="accessory-button"

nit: indent should align with the id attribute.
Attachment #8952310 - Flags: review?(nhnt11)
Comment on attachment 8952310 [details]
Bug 1436568 - Make "clear your recent history" a button instead of a link.

https://reviewboard.mozilla.org/r/221562/#review228564
Attachment #8952310 - Flags: review?(nhnt11) → review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce6adae0faa1
Make "clear your recent history" a button instead of a link. r=nhnt11
https://hg.mozilla.org/mozilla-central/rev/ce6adae0faa1
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
I have reproduced this bug with Nightly 60.0a1 (2018-02-07) on Windows 10, 64 Bit!

This bug's fix is verified with latest Nightly!

Build ID   : 20180225100219
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
QA Whiteboard: [bugday-20180221]
Depends on: 1442887
Verified fixed using Nightly 61.0a1(2018-03-13) and Beta 60.0b3 on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.