Closed
Bug 1436571
Opened 8 years ago
Closed 8 years ago
Move getCalendarDirectory into calProviderUtils.jsm
Categories
(Calendar :: Internal Components, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
6.2
People
(Reporter: Fallen, Assigned: Fallen)
References
Details
Attachments
(1 file)
|
4.79 KB,
patch
|
MakeMyDay
:
review+
|
Details | Diff | Splinter Review |
This function is only used by the providers right now. I'm fine with moving it somewhere else instead, but this seemed acceptable.
|
Assignee | |
Comment 1•8 years ago
|
||
In patch order, this is after bug 1436557.
Attachment #8949202 -
Flags: review?(makemyday)
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0a2e7d1cf4dbbb9cc445adf9086fb84557d11fb0
Looks pretty much like comm-central right now.
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8949202 [details] [diff] [review]
Fix - v1
Review of attachment 8949202 [details] [diff] [review]:
-----------------------------------------------------------------
looks good, r=me
Attachment #8949202 -
Flags: review?(makemyday) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
Please push both the automatic and manual patches, after the bug mentioned in comment 1.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f1a768d1bbed
Move getCalendarDirectory into calProviderUtils.jsm. r=MakeMyDay
|
||
Updated•8 years ago
|
Target Milestone: --- → 6.2
You need to log in
before you can comment on or make changes to this bug.
Description
•