1436614 - Add ghost window metric to Memory.jsm

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement)

Description

[Eric Rahm [:erahm]]

It would be useful to be able to retrieve the ghost window count of all windows. This would be the basis for adding extensions that can surface this info visually in order to help proactively debug ghost windows.

I envision this tying in with the experimental memory WebExtension API (bug 1296898).

Comment 1

[Eric Rahm [:erahm]]

Attachment: Report ghost windows in Memory.jsm

This adds a 'ghosts' field to the object returned by Memory.summary.

Mike, this is a super simple change but feel free to redirect if you're not the
right person to review it.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8949253 [details] [diff] [review]
Report ghost windows in Memory.jsm

Review of attachment 8949253 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! Is this going to be part of that WebExtension API you're experimenting with?

Comment 3

[Eric Rahm [:erahm]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #2)
> Comment on attachment 8949253 [details] [diff] [review]
> Report ghost windows in Memory.jsm
> 
> Review of attachment 8949253 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, thanks! Is this going to be part of that WebExtension API you're
> experimenting with?

Yeah that's my plan. Thanks for the quick review!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/21f73ed97e6a
Report ghost windows in Memory.jsm. r=mconley

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/21f73ed97e6a