1436643 - Use a PLDHashTable `initEntry` function for Pref.

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement)

Description

[Nicholas Nethercote [inactive]]

A small improvement.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1436643 - Use a PLDHashTable `initEntry` function for Pref.

This lets us have a proper constructor for Pref, which is nice.

The patch also adds a missing case to PrefTypeToString(), and reorders the
fields in Pref to be more sensible.

Review commit: https://reviewboard.mozilla.org/r/218644/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218644/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8949276 [details]
Bug 1436643 - Use a PLDHashTable `initEntry` function for Pref.

https://reviewboard.mozilla.org/r/218644/#review224810

Thanks, proper initialization is always nice.

::: modules/libpref/Preferences.cpp:365
(Diff revision 1)
> +    auto pref = static_cast<Pref*>(aEntry);
> +    auto prefName = static_cast<const char*>(aKey);

We don't have anything in the style guide about this, but I find `auto*` slightly nicer for cases like this.  WDYT?  (I guess it's not local style, either...)

Comment 3

[Nicholas Nethercote [inactive]]

> > +    auto prefName = static_cast<const char*>(aKey);
> 
> We don't have anything in the style guide about this, but I find `auto*`
> slightly nicer for cases like this.  WDYT? 

My opinion is that the type is present on the RHS, so there is no point duplicating any part of it on the LHS.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5cd9cebf800b3b941731c608d89b71ce1897f6a0
Bug 1436643 - Use a PLDHashTable `initEntry` function for Pref. r=froydnj

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5cd9cebf800b