143665 - Remove the .bg mirror link.

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Yanko Kaneti]

The .bg mirror link should be removed. The ftp is live but there is no mozilla
mirror currently there.

Comment 1

[rudman]

Not a doc bug. Changing Product designation.

Comment 2

[Yanko Kaneti]

It seems this was fixed...

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 143665 - Rename pref_SetPref()'s aFromFile argument as aFromInit.

Currently all pref initialization is done from file, but soon we will also be
initializing prefs from code compiled into the binary. The new name encompasses
both cases.

Review commit: https://reviewboard.mozilla.org/r/218664/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218664/

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: Bug 143665 - Introduce a mechanism for VarCache prefs to be defined entirely in the binary.

[XXX: The draft patch implements the mechanism and converts a subset of
representative prefs to the new mechanism. For landing I will have one patch
that implements the mechanism, multiple patches converting prefs, and then a
final clean-up patch that removes stuff no longer needed.]

Currently VarCache prefs are setup in two parts:

- The vanilla pref part, installed via a data file such as all.js, or via an
  API call.

- The VarCache variable part, setup by an Add*VarCache() call.

Both parts are needed for the pref to actually operate as a proper VarCache
pref. (There are various prefs for which we do one but not the other unless a
certain condition is met.)

This patch introduces a new way of doing things. There is a new file,
modules/libpref/init/All.h, which defines prefs like this:

> PRF("layout.accessiblecaret.width",
>     layout__accessiblecaret__width,
>     float, "34.0");

This replaces both the existing parts.

The preprocessor is used to generate multiple things from this single
definition:

- A global variable (the VarCache itself).

- A getter for that global variable.

- A call to a registration function that unconditionally installs the pref in
  the prefs hash table at startup.

C++ files can include the new StaticPrefs.h file to access the getter.

Rust code cannot use the getter, but can access the global variable directly
via structs.rs. This is similar to how things currently work for Rust code.

The new approach has the following advantages.

+ It eliminates the duplication (in all.js and the Add*VarCache() call) of the
  pref name and default value, preventing potential mismatches. (This is a real
  problem in practice!)

+ There is now a single initialization point for these VarCache prefs.
  + This avoids need to find a place to insert the Add*VarCache() calls, which
    are currently spread all over the place.
  + It also eliminates the common pattern whereby these calls are wrapped in a
    execute-once block protected by a static boolean (see bug 1346224).
  + And it's no longer possible to have a VarCache pref for which only one of
    the pieces has been setup.

+ It encapsulates the VarCache global variable, so there is no need to declare
  them separately.

+ VarCache reads are done via a getter (e.g. StaticPrefs::foo__bar__baz())
  instead of a raw global variable read.
  + This makes it clearer that you're reading a pref value.
  + This provides a single chokepoint in the code for such accesses, which make
    adding checking and instrumentation feasible.

+ It completely replaces MediaPrefs.h.

+ [XXX: not yet prototyped] It completely replaces gfxPrefs.h.

+ Once all VarCache prefs are migrated to the new approach, the VarCache
  mechanism will be better encapsulated, with fewer details publicly visible.

+ (Future work) This will allow the pref names to be stored statically, saving
  memory in every process.

The main downside of the new approach is that all of these prefs are in a
single header that is included in quite a few places, so any changes to this
header will cause a fair amount of recompilation.

Review commit: https://reviewboard.mozilla.org/r/218666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218666/

Comment 5

[Nicholas Nethercote [inactive]]

Comment on attachment 8949286 [details]
Bug 143665 - Rename pref_SetPref()'s aFromFile argument as aFromInit.

Sorry, wrong bug number.

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 8949287 [details]
Bug 143665 - Introduce a mechanism for VarCache prefs to be defined entirely in the binary.

Sorry, wrong bug number.