1436663 - Hits warning assertion The offset is out of bounds: '!mParent || mOffset.value() <= mParent->Length()' EditorDOMPoint.h, line 373 in EditorBase::JoinNodeDeep()

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

>  0:42.83 pid:78184 [Child 137044, Main Thread] ###!!! ASSERTION: The offset is out of bounds: '!mParent || mOffset.value() <= mParent->Length()', file c:\mozilla\fx64-dbg\dist\include\mozilla/EditorDOMPoint.h, line 373
>  0:42.83 pid:78184 #01: mozilla::EditorBase::JoinNodeDeep (c:\mozilla\src\editor\libeditor\editorbase.cpp:4377)
>  0:42.84 pid:78184 #02: mozilla::HTMLEditRules::WillDeleteSelection (c:\mozilla\src\editor\libeditor\htmleditrules.cpp:2700)
>  0:42.84 pid:78184 #03: mozilla::HTMLEditRules::WillDoAction (c:\mozilla\src\editor\libeditor\htmleditrules.cpp:641)
>  0:42.84 pid:78184 #04: mozilla::TextEditor::DeleteSelection (c:\mozilla\src\editor\libeditor\texteditor.cpp:668)
>  0:42.84 pid:78184 #05: mozilla::DeleteCommand::DoCommand (c:\mozilla\src\editor\libeditor\editorcommands.cpp:791)
>  0:42.84 pid:78184 #06: nsControllerCommandTable::DoCommand (c:\mozilla\src\dom\commandhandler\nscontrollercommandtable.cpp:147)
>  0:42.84 pid:78184 #07: nsBaseCommandController::DoCommand (c:\mozilla\src\dom\commandhandler\nsbasecommandcontroller.cpp:136)
>  0:42.84 pid:78184 #08: nsCommandManager::DoCommand (c:\mozilla\src\dom\commandhandler\nscommandmanager.cpp:214)
>  0:42.84 pid:78184 #09: nsHTMLDocument::ExecCommand (c:\mozilla\src\dom\html\nshtmldocument.cpp:3091)
>  0:42.84 pid:78184 #10: mozilla::dom::HTMLDocumentBinding::execCommand (c:\mozilla\fx64-dbg\dom\bindings\htmldocumentbinding.cpp:776)
>  0:42.84 pid:78184 #11: mozilla::dom::GenericBindingMethod (c:\mozilla\src\dom\bindings\bindingutils.cpp:3035)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c19f5f708eb4a78f529e95202b78c36429629de

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff5080def82944888c1d94c432e13e2fdc266da8

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1436663 - EditorBase::JoinNodeDeep() should set result after actually joining the nodes

EditorBase::JoinNodeDeep() returns a DOM point which was start of right node.
Currently, this is set before actually joining the nodes.  Therefore, we see
warnings since right node which becomes joined node may have less children
than left node.

This patch also makes the NS_WARNING_ASSERTION to NS_ASSERTION since no tests
hit this.  So, we can use it to detect regressions.

Review commit: https://reviewboard.mozilla.org/r/218998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218998/

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8949640 [details]
Bug 1436663 - EditorBase::JoinNodeDeep() should set result after actually joining the nodes

https://reviewboard.mozilla.org/r/218998/#review225038

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/216fac39a9f4
EditorBase::JoinNodeDeep() should set result after actually joining the nodes r=m_kato

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/216fac39a9f4