1436664 - Creating new ICS cal (posteo.de) fails with "Component returned failure code: 0x804a0104 [calIDateTime.icalString]"

Status: UNCONFIRMED

(Calendar :: General, defect)

Description

[gerd.neumann]

Attachment: Auswahl_192.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180207100355

Steps to reproduce:

Create a new ics calendaer to subscribe to. The calender is my personal posteo.de (something like a german google cal with privacy in mind). It works using other software, e.g ICSDroid on Android.


Actual results:

From UI it looks like the calender is successfully created. Only problem, no events are shown whatsoever. I tried on two different computers (both Ubuntu 16.04), all the same. Using Lightning 5.4 released on 20. May 2017 according to the addon page of Thunderbird.


Expected results:

Events should be created, probably also in case of an Error the UI should give a notice to the user.

Attached is a screenshot.

Error message is in Error console is:
> Component returned failure code: 0x804a0104 [calIDateTime.icalString]

function _calIcalCreator(cid, iid) {
    return function(icalString) {
        let thing = Components.classes[cid].createInstance(iid);
        if (icalString) {
            VVVVVVVVVV THIS LINE VVVVVVVVVVVVVV
            thing.icalString = icalString;
            ^^^^^^^^ THIS LINE ^^^^^^^^^^^^
        }
        return thing;
    };
}

The ics in question is my private calender (it has no password but a very long cryptic URL path) so I would not like to share it publicly on the internet. But you can leave a comment here with NIing me, then I could sent it to you via e-mail. My mail is nachtigall ((at)) web (dot) de

Comment 1

[Stefan Sitter [:ssitter]]

What version of Thunderbird do you use? What version of Lightning do you use?

Does Lightning read the calendar correctly if you manually download the .ics file to local disc and open it using menu File > Open > Calendar File?

Could you retest with advanced preferences "calendar.debug.log" and "calendar.debug.log.verbose" set to true? Maybe additional information is logged to Error Console that helps to investigate the problem or to identify the faulty event.

Comment 2

[Stefan Sitter [:ssitter]]

According to <https://wiki.mozilla.org/Calendar:Error_Codes> 0x804a0104 is ICAL_MALFORMEDDATA_ERROR "An input string was not correctly formed or a component has missing or extra properties" indicating that something is wrong with the calendar.

Comment 3

[Jens]

Attachment: calendar.ics

Hey, thanks for looking into it :)

Using Thunderbirg 52.6.0 (64-Bit) with Lightning 5.4 under Ubuntu 16.04.

Enabling verbose debugging does not add much more information.

Opening the file directly results in the same error. So it seems like it is an error reading the ics file. I have attached the file so you can debug / reproduce the bug.

I never had a problem before with the ics files from posteo.de and I also checked against the following ics validator (which complains against \n as newlines and not \r\n but severe afaict):
https://icalendar.org/validator.html
http://severinghaus.org/projects/icv/
http://ical-validator.herokuapp.com/

So I see two problems here:

1. Even if there is an error with the ics then it should fail more gracefully. In case there's no indication to the user that something failed. The calendar is created but there are just not events in it. There should be an error message telling the user that the ics could not be read because it was supposed to be invalid (ideally, naming the line / event which could not be read)

2. Well, I think the ics attached is actually valid and there's a bug in Lightning or a lib that causes to fail parsing it.

Comment 4

[[:MakeMyDay]]

There is an issue with this event with our x-props, which let us fail:

>BEGIN:VEVENT
>CREATED;VALUE=DATE-TIME:20180130T220136Z
>DTEND;TZID=Europe/Berlin;VALUE=DATE-TIME:20180208T180000
>DTSTART;TZID=Europe/Berlin;VALUE=DATE-TIME:20180208T160000
>TRANSP:OPAQUE
>DTSTAMP;VALUE=DATE-TIME:20180207T150107Z
>LAST-MODIFIED;VALUE=DATE-TIME:20180207T150107Z
>UID:3656a623-4d6e-4c3a-a892-088d079d7e61
>SUMMARY:ucf
>X-MOZ-LASTACK::20180207T150107Z
>X-MOZ-GENERATION::1
>BEGIN:VALARM
>TRIGGER;VALUE=DURATION:-P1D
>DESCRIPTION:Mozilla Standardbeschreibung
>ACTION:DISPLAY
>END:VALARM
>END:VEVENT

Do you still know whether you created/modified/dismissed the alarm using Lightning or another client? Are you using other TB addons or just Lightning?

If you remove this event from the calendar (e.g. by usaing a different client), can you please try to reproduce the issue by modifying another event form the calendar (what you modify doesn't matter)?

To do so, please enable calendar.debug.log and calendar.debug.log.verbose beforehand and then post here any logged message written from opening the event until re-retrieving the event from the server after saving.

Comment 5

[Jens]

(In reply to [:MakeMyDay] from comment #4)
> Do you still know whether you created/modified/dismissed the alarm using
> Lightning or another client? 

I pretty sure created it with Lightning. I think I never modified it. I think I dismissed it probably with my Android cal app (acalendar+, or Davdroid), but I am not sure here. I also managed to reproduce while disabling this calendar from my Android, so I should be only Lightning "modifying" the event.

> Are you using other TB addons or just Lightning?

No, I use some more:
 Name 	Version 	Aktiviert 	ID
Display Mail User Agent	1.7.0	true	{F8147CF4-B9E3-445B-AA87-081ED66548F8}
Display Quota	0.3.7	true	{c1ac4523-76c2-9995-adbd-d93bf5141bea}
Enigmail	1.9.9	true	{847b3a00-7ab1-11d4-8f02-006008948af5}
Lightning	5.4	true	{e2fda1a4-762b-4020-b5ad-a41df1933103}
Mail Merge	4.11.0	true	[e-mail]
Manually Sort Folders	1.1.1	true	[e-mail]
Messaging Menu and Unity Launcher integration	1.3.1	true	[e-mail]
ThreadKey	0.7	true	{1a2d9681-ba56-11da-959b-00e08161165f}
Toggle Word Wrap	1.10	true	{cafe3945-058e-47e3-87f8-75bc120b9638}
ICS Inspector	1.4	false	{3dcf3762-4cda-4fd2-be13-13b9a10769fd}
ThunderBirthDay	0.8.2	false	{4C9FE6FE-2C83-11DC-90B4-DC8456D89593}
ThunderSync	2.6	false	[e-mail]


> 
> If you remove this event from the calendar (e.g. by usaing a different
> client), can you please try to reproduce the issue by modifying another
> event form the calendar (what you modify doesn't matter)?

It is reproducable.

On Computer Anton (the calendar "owner"):
1. Create an event in Lightning with an alarm, e.g. at 17:58 create an event starting at 19:00 at set alarm to be one hour in advance. The calendar is called "Familie". Just use the caldav protocol for creating this event; it's a normal posteo.de calendar.

On Computer Britta (the "subscriber"):
1. Subscribe to this cal via ics in Thunderbird (posteo exports caldav calendars as ics so that other family members can subscribe read-only). This works.

On Computer Anton:
When Alarm comes, then dismiss (just close the Lightning popup). The caldav calendar still works fine.

On Computer Britta:
Delete the existing ics calendar in Lightning and try to re-create it: Same error in the Error console. 

When trying to reproduce, one time the error also popped up when trying just to synchronize the ics cal, another time I really had to re-create. But this, I think, might have been more a caching issue that the dismissed information was not propagated yet maybe.

> To do so, please enable calendar.debug.log and calendar.debug.log.verbose
> beforehand and then post here any logged message written from opening the
> event until re-retrieving the event from the server after saving.

Hmm, there's not much information in there in my opinion. Please also note, that for reproducing the issue in my case Computer A (caldav, read-write) and Computer B (ics, read) where on the same Laptop. Anyway, I attached it.

Comment 6

[Jens]

Attachment: lightning.log

I forgot the log, it is attached now. Please note, that I mask some confidental infos with XXX.

Comment 7

[[:MakeMyDay]]

Thanks, but you probably haven't enabled calendar.debug.log and calendar.debug.log.verbose in the advanced log before, so the event details are missing in the log.

To be sure the calendar cache isn't masking a problem already with the caldav calendar, please disable the offline support for that calendar before reproducing as well as all of you addons except Lightning and restart TB.

Interesting would be the logging sequences when creating / updating / alarm dismissing on the caldav calendar.

Please also provide on which exact version of Lightning you are (available in the addons manager): 5.4 or any of the 5.4.x releases?

Comment 8

[Jens]

(In reply to [:MakeMyDay] from comment #7)
> Thanks, but you probably haven't enabled calendar.debug.log and
> calendar.debug.log.verbose in the advanced log before, so the event details
> are missing in the log.

Not sure we are talking about the same things here. When I got to Edit > Settings > Advanced tab > Edit Configuration I have this:

http://storage2.static.itmages.com/i/18/0210/h_1518291999_9195248_974d718448.png

Then I go to Extras > Developer Tool > Error console where I have the filters as they are by default. But I guess only "JS" filter is important which is that all three Errors, Warnings, Logs are enabled. Only the "Server" filter is completely disabled - not sure this is important. 

With this there seems to be nothing else than what I sent, or do I need to restart TB?

> To be sure the calendar cache isn't masking a problem already with the
> caldav calendar, please disable the offline support for that calendar before
> reproducing as well as all of you addons except Lightning and restart TB.
> 
> Interesting would be the logging sequences when creating / updating / alarm
> dismissing on the caldav calendar.

Ok, I'll do once the above is clarified.

> Please also provide on which exact version of Lightning you are (available
> in the addons manager): 5.4 or any of the 5.4.x releases?

Well, the addons page says 5.4:

http://storage4.static.itmages.com/i/18/0210/h_1518292298_2135635_7b3d3f1718.png
http://storage7.static.itmages.com/i/18/0210/h_1518292373_9066350_c268d4b3de.png

Comment 9

[Jens]

Attachment: large-lightning.log (Creating ics, Adding event with Reminder, Dismissing, Syncing => Error

Here's very large log with all the actions. In the last step when reading the updated (dismissed) event, then the error happens.

Running without any other addons beside Lightning and with verbose logging. 

It is Lightning version 5.4 (no 5.4.x). See info above.

Does this help, do you need anything more? (And thanks for looking into this, very much appreciated :)