Closed Bug 1436674 Opened 2 years ago Closed 5 months ago

nsICookieService.idl should use ACString XPIDL type in place of the string type

Categories

(Core :: Networking: Cookies, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: hsivonen, Assigned: baku)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

I noticed that nsICookieService.idl uses C strings instead of XPCOM strings for cookie headers when modifying nsReadableUtils.h.

We should get rid of plain C string in XPIDL.

This is messier to change than it first looks (which is why I gave up on fixing it myself), because the cookie code doesn't follow our string guide for its XPCOM string usage (it has nsDependentCString, etc., as argument types).
Priority: -- → P3
Whiteboard: [necko-triaged]
Assignee: nobody → amarchesini
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad895c9bac52
nsICookieService.idl should use ACString XPIDL type in place of the string type, r=Ehsan
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.