1436702 - signature summary product table should match the behavior of the rest of the summary

Status: RESOLVED FIXED

(Socorro :: General, task, P2)

Description

[Jonathan Watt [:jwatt]]

The source of the data I provided in bug 1435495 comment 2 for the number of crashes per beta was:

https://crash-stats.mozilla.com/signature/?_sort=-date&signature=nsPrintJob%3A%3ADonePrintingPages&date=%3E%3D2017-11-08T10%3A44%3A55.000Z&date=%3C2018-02-08T10%3A44%3A55.000Z

I searched for the crashes from the last three months, and at the top of this page it says:

  Showing results from 3 months ago to 3 minutes ago

Like most people, I automatically lock in on the parts of the info presented to me that I'm interested in - in this case the crash counts per beta. Since I know that I searched for the stats for the last three months (I even noticed that it was confirmed that's what I was being presented with) this seems reasonable, and I used this data for my comment over in bug 1435495.

Later on I and jcristau	discover the numbers we're working from don't match up, and it turns out this is because the table is NOT three months worth of data. There's even a little footnote to the table I was using saying "This summary does not use any of the filters defined above except the signature. The date range is from 7 days ago to now" ... not that people are going to reliably notice that. It's a very human tendency to filter out "extraneous" information when scanning for what you need in a context you think you understand. Violating the understanding of that context and expecting people to not scan and filter is bad UI.

As a temporary measure, please make the footnote ALL UPPERCASE and red.

As a fuller fix this table should match the search criteria that the rest of the page honors, and that the top of the page says that the page honors! If there are serious technical reasons this is difficult then please separate the table from the data that honors the search criteria.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm sorry that this was so frustrating. I'd accept a PR if someone has time. Otherwise, this is going to sit for a while.

Comment 2

[Jonathan Watt [:jwatt]]

I created https://github.com/mozilla-services/socorro/pull/4330

I don't think that should count as fixing this bug though.

Comment 3

[Lonnen :lonnen]

I dug up why this particular artifact exists. It was the specific request of a crash investigator that's no longer here. I agree that this is misleading. We should adjust the behavior to match the context.

for history, see:
https://bugzilla.mozilla.org/show_bug.cgi?id=1225567#c4

I'm going to close out the current pull request. Altering the warning visually may draw attention to it the next time someone is on the page, but it will quickly get filtered out as noise as well.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Tossing this at Alexis.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/c64bdce988207b47c123e9ee7bf1b841fe804a3f
fix bug 1436702: fixed summary product table

- made the Signature’s Summary tab’ Product table respect the selected filters for the signature report

Previously, this table had behavior different from the other tables to make it display data from the last 7 days instead of the data range specified in the filters.
- this was a specific request of a crash investigator that is no longer here
- this created confusion for users

https://github.com/mozilla-services/socorro/commit/a57e34fdf7d21ec85bc8c8d5f94774361f74409b
Merge pull request #4492 from mozilla-services/signature-summary-product

fix bug 1436702: made the Signature Summary tab Product table respect the selected filters