symbolapi.mozilla.org is deprecated in favor of symbols.mozilla.org

RESOLVED FIXED in Firefox 60

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: peterbe, Assigned: apoorvgoel_bt2k16, Mentored)

Tracking

unspecified
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
On about:telemetry#chrome-hangs-tab the "Fetch function names for stacks" uses http://symbolapi.mozilla.org/ [0]

That service is deprecated and uses HTTP. The URL it should use is https://symbols.mozilla.org/symbolicate/v4


[0] https://searchfox.org/mozilla-central/source/toolkit/content/aboutTelemetry.js#34
(Reporter)

Comment 1

a year ago
David, 
I don't know if that's your team working on that, or if this bug is even in the right component. But I suspect you'll do a better job than me to drive this bug.
Flags: needinfo?(ddurst)
(I'm not Durst, but I was on his team once)

Is the API identical? Is it just a string swap? I can set this up as a good-first-bug, if so.
Flags: needinfo?(ddurst) → needinfo?(peterbe)
(Reporter)

Comment 3

a year ago
(In reply to Chris H-C :chutten from comment #2)
> (I'm not Durst, but I was on his team once)
> 
> Is the API identical? Is it just a string swap? I can set this up as a
> good-first-bug, if so.

Yes, it should be identical. 

But the old symbolapi.mozilla.org used to use the / path. Now you need to use /symbolicate/v4 and the API is identical.
Flags: needinfo?(peterbe)
To help Mozilla out with this bug, here's the steps:

0) Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
1) Download and build the Firefox source code: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
- If you have any problems, please ask on IRC (https://wiki.mozilla.org/Irc) in the #introduction channel. They're there to help you get started.
- You can also read the Developer Guide, which has answers to most development questions: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
2) Change the code as described in comment#0.
- If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC (https://wiki.mozilla.org/Irc) most hours of most days.
3) Build your change with `mach build` and test your change by running your built code with `mach run` and testing that about:telemetry loads without any errors in the console.
4) Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code.
- Here's the guide: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
5) After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
6) ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
Mentor: chutten
Whiteboard: [good first bug][lang=js]
(Assignee)

Comment 5

a year ago
Hello! I would like to help out with this bug.
Oh good! I've assigned it to you. Please let me know if you have any questions.
Assignee: nobody → ap.goel98
Status: NEW → ASSIGNED
(Assignee)

Comment 7

a year ago
Please review this patch. Hopefully, this fixes the bug.
Attachment #8949956 - Flags: review?(chutten)
Priority: -- → P3
Comment on attachment 8949956 [details] [diff] [review]
symbol_server_uri.patch

Review of attachment 8949956 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!
Attachment #8949956 - Flags: review?(chutten) → review+
Thank you for your contribution!

I have marked it as needing checkin. It should shortly make it into the source tree which will allow it to be built into Nightly instances for the world to enjoy!

Would you like some help finding the next bug you would like to work on, or have you found one already? If you'd like some help, if you tell me what you're interested in I will have better chance of finding you something interesting.
Keywords: checkin-needed
(Assignee)

Comment 10

a year ago
Thank you for accepting this patch!
I would like it very much to work on something related to the Gecko core. Preferably something in C or C++.
I am not sure if this is the correct place to discuss this, I apologise if it is not.
Hrm. I don't know of any within Telemetry at the moment... (bug 1186210 isn't technically a Telemetry bug, even though it's in the Telemetry component. But that doesn't matter, it might still be a good "getting started" bug)

The Big List of good first bugs is here: https://www.joshmatthews.net/bugsahoy/?cpp=1

From there bug 1277133 is deep in Gecko (deals with CSS), and bug 1070763 is an older one about how XMLHttpRequest deals with responseText.

Do any of those seem promising?
(Assignee)

Comment 12

a year ago
Bug 1277133 looks nice, I will take a look at it.

Comment 13

a year ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbd3f732b46b
Replace symbolapi.mozilla.org with symbols.mozilla.org. r=chutten
Keywords: checkin-needed

Comment 14

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dbd3f732b46b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.